Add some debugging to buildbot_globals, sort the trybot list

Add some debugging to buildbot_globals, sort the trybot list

R=epoger@google.com, rmistry@google.com

Committed: https://code.google.com/p/skia/source/detail?r=12437

[rmistry, 2013-12-02 14:57:12]

LGTM

https://codereview.chromium.org/99223002/diff/1/tools/buildbot_globals.py
File tools/buildbot_globals.py (right):

https://codereview.chromium.org/99223002/diff/1/tools/buildbot_globals.py#new...
tools/buildbot_globals.py:25: class JsonDecodeError(Exception):
simplejson has a JSONDecodeError. Also, I wonder if we should be using
simplejson everywhere instead of json.

[borenet, 2013-12-02 16:26:29]

https://codereview.chromium.org/99223002/diff/1/tools/buildbot_globals.py
File tools/buildbot_globals.py (right):

https://codereview.chromium.org/99223002/diff/1/tools/buildbot_globals.py#new...
tools/buildbot_globals.py:25: class JsonDecodeError(Exception):
On 2013/12/02 14:57:12, rmistry wrote:
> simplejson has a JSONDecodeError. Also, I wonder if we should be using
> simplejson everywhere instead of json.

Probably a good decision in the long run.  All I care about with this change is
getting better error messages; if simplejson can provide that, great!  For now,
I'd like to keep using the json module, since some bots (I tested the GCE bots)
don't have simplejson installed, and I'm hesitant to add another dependency
unless we really need it.

[rmistry, 2013-12-02 16:28:23]

https://codereview.chromium.org/99223002/diff/1/tools/buildbot_globals.py
File tools/buildbot_globals.py (right):

https://codereview.chromium.org/99223002/diff/1/tools/buildbot_globals.py#new...
tools/buildbot_globals.py:25: class JsonDecodeError(Exception):
On 2013/12/02 16:26:29, borenet wrote:
> On 2013/12/02 14:57:12, rmistry wrote:
> > simplejson has a JSONDecodeError. Also, I wonder if we should be using
> > simplejson everywhere instead of json.
> 
> Probably a good decision in the long run.  All I care about with this change
is
> getting better error messages; if simplejson can provide that, great!  For
now,
> I'd like to keep using the json module, since some bots (I tested the GCE
bots)
> don't have simplejson installed, and I'm hesitant to add another dependency
> unless we really need it.

Makes sense.

[epoger, 2013-12-02 18:36:28]

LGTM with or without minor suggestions

https://codereview.chromium.org/99223002/diff/1/tools/buildbot_globals.py
File tools/buildbot_globals.py (right):

https://codereview.chromium.org/99223002/diff/1/tools/buildbot_globals.py#new...
tools/buildbot_globals.py:17: GLOBAL_VARS_JSON_URL =
('http://skia.googlecode.com/svn/buildbot/site_config/'
Personally, I would write it this way so the URL would not be split (thus giving
better results if someone is grepping thru the code):

GLOBAL_VARS_JSON_URL = (
    'http://skia.googlecode.com/svn/buildbot/site_config/global_variables.json')

But either way is fine.

Damn you, Python.

https://codereview.chromium.org/99223002/diff/1/tools/buildbot_globals.py#new...
tools/buildbot_globals.py:21: class GlobalVarsRetrievalError(Exception):
Please add docstrings giving a brief description of these new Exceptions (what
it means if one is raised)

https://codereview.chromium.org/99223002/diff/1/tools/buildbot_globals.py#new...
tools/buildbot_globals.py:40: except Exception:
TL;DR : this is fine. :-)

I wondered what the pros and cons of "except Exception:" (vs. just "except:")
were, which led me to http://docs.python.org/2/howto/doanddont.html#except

So it's better to specify Exception, like you did.

Unfortunately, it looks like there is no really great way of wrapping exceptions
in Python 2.x.  There's an interesting writeup at
http://www.ianbicking.org/blog/2007/09/re-raising-exceptions.html

[borenet, 2013-12-02 20:22:24]

Uploaded patch set 2.

https://codereview.chromium.org/99223002/diff/1/tools/buildbot_globals.py
File tools/buildbot_globals.py (right):

https://codereview.chromium.org/99223002/diff/1/tools/buildbot_globals.py#new...
tools/buildbot_globals.py:17: GLOBAL_VARS_JSON_URL =
('http://skia.googlecode.com/svn/buildbot/site_config/'
On 2013/12/02 18:36:28, epoger wrote:
> Personally, I would write it this way so the URL would not be split (thus
giving
> better results if someone is grepping thru the code):
> 
> GLOBAL_VARS_JSON_URL = (
>    
'http://skia.googlecode.com/svn/buildbot/site_config/global_variables.json')
> 
> But either way is fine.
> 
> Damn you, Python.

Done.

https://codereview.chromium.org/99223002/diff/1/tools/buildbot_globals.py#new...
tools/buildbot_globals.py:21: class GlobalVarsRetrievalError(Exception):
On 2013/12/02 18:36:28, epoger wrote:
> Please add docstrings giving a brief description of these new Exceptions (what
> it means if one is raised)

Done.

https://codereview.chromium.org/99223002/diff/1/tools/buildbot_globals.py#new...
tools/buildbot_globals.py:40: except Exception:
On 2013/12/02 18:36:28, epoger wrote:
> TL;DR : this is fine. :-)
> 
> I wondered what the pros and cons of "except Exception:" (vs. just "except:")
> were, which led me to http://docs.python.org/2/howto/doanddont.html#except
> 
> So it's better to specify Exception, like you did.
> 
> Unfortunately, it looks like there is no really great way of wrapping
exceptions
> in Python 2.x.  There's an interesting writeup at
> http://www.ianbicking.org/blog/2007/09/re-raising-exceptions.html

Yeah, I guess this isn't ideal, but losing the stack trace here isn't a big
deal, since there's not much code in the try blocks.

[borenet, 2013-12-02 20:27:19]

Committed patchset #2 manually as r12437 (presubmit successful).