[S.P.] Move filter painting to SVGFilterPainter.

[S.P.] Move filter painting to SVGFilterPainter.

BUG=462077
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191645

[Erik Dahlström (inactive), 2015-03-10 11:30:14]

ed@opera.com changed reviewers:
+ fs@opera.com, pdr@chromium.org

[fs, 2015-03-10 12:12:01]

https://codereview.chromium.org/992213002/diff/1/Source/core/layout/svg/Layou...
File Source/core/layout/svg/LayoutSVGResourceFilter.cpp (right):

https://codereview.chromium.org/992213002/diff/1/Source/core/layout/svg/Layou...
Source/core/layout/svg/LayoutSVGResourceFilter.cpp:31: #include
"platform/graphics/filters/SourceGraphic.h"
Don't think this is needed anymore.

https://codereview.chromium.org/992213002/diff/1/Source/core/layout/svg/Layou...
Source/core/layout/svg/LayoutSVGResourceFilter.cpp:141: FilterData*
LayoutSVGResourceFilter::getFilterToPaint(LayoutObject* object)
getFilterDataForLayoutObject?

https://codereview.chromium.org/992213002/diff/1/Source/core/layout/svg/Layou...
Source/core/layout/svg/LayoutSVGResourceFilter.cpp:150: if (filterData->m_state
== FilterData::PaintingFilterCycleDetected) {
I don't think we should do this here - it's probably better to keep this just
doing the simple map-lookup and nothing else. so this block should go back
"where it came from" (we mutate FilterData::m_state in the caller anyway so no
need to hide it for that reason.)

https://codereview.chromium.org/992213002/diff/1/Source/core/layout/svg/Layou...
Source/core/layout/svg/LayoutSVGResourceFilter.cpp:158: bool
LayoutSVGResourceFilter::hasCycle(LayoutObject* object)
This method is not really just "hasCycle" (more like "has valid FilterData - and
possibly cycle".) Like above I think this should go in the caller, so this
method wouldn't be needed.

[Erik Dahlström (inactive), 2015-03-10 14:39:27]

https://codereview.chromium.org/992213002/diff/1/Source/core/layout/svg/Layou...
File Source/core/layout/svg/LayoutSVGResourceFilter.cpp (right):

https://codereview.chromium.org/992213002/diff/1/Source/core/layout/svg/Layou...
Source/core/layout/svg/LayoutSVGResourceFilter.cpp:31: #include
"platform/graphics/filters/SourceGraphic.h"
On 2015/03/10 12:12:01, fs wrote:
> Don't think this is needed anymore.

Still used by LayoutSVGResourceFilter::buildPrimitives().

https://codereview.chromium.org/992213002/diff/1/Source/core/layout/svg/Layou...
Source/core/layout/svg/LayoutSVGResourceFilter.cpp:141: FilterData*
LayoutSVGResourceFilter::getFilterToPaint(LayoutObject* object)
On 2015/03/10 12:12:01, fs wrote:
> getFilterDataForLayoutObject?

Done.

I renamed the corresponding setter the same way in patchset #3.

https://codereview.chromium.org/992213002/diff/1/Source/core/layout/svg/Layou...
Source/core/layout/svg/LayoutSVGResourceFilter.cpp:150: if (filterData->m_state
== FilterData::PaintingFilterCycleDetected) {
On 2015/03/10 12:12:01, fs wrote:
> I don't think we should do this here - it's probably better to keep this just
> doing the simple map-lookup and nothing else. so this block should go back
> "where it came from" (we mutate FilterData::m_state in the caller anyway so no
> need to hide it for that reason.)

Done.

https://codereview.chromium.org/992213002/diff/1/Source/core/layout/svg/Layou...
Source/core/layout/svg/LayoutSVGResourceFilter.cpp:158: bool
LayoutSVGResourceFilter::hasCycle(LayoutObject* object)
On 2015/03/10 12:12:01, fs wrote:
> This method is not really just "hasCycle" (more like "has valid FilterData -
and
> possibly cycle".) Like above I think this should go in the caller, so this
> method wouldn't be needed.

Done.

[fs, 2015-03-10 14:48:56]

lgtm

https://codereview.chromium.org/992213002/diff/1/Source/core/layout/svg/Layou...
File Source/core/layout/svg/LayoutSVGResourceFilter.cpp (right):

https://codereview.chromium.org/992213002/diff/1/Source/core/layout/svg/Layou...
Source/core/layout/svg/LayoutSVGResourceFilter.cpp:31: #include
"platform/graphics/filters/SourceGraphic.h"
On 2015/03/10 14:39:27, Erik Dahlström wrote:
> On 2015/03/10 12:12:01, fs wrote:
> > Don't think this is needed anymore.
> 
> Still used by LayoutSVGResourceFilter::buildPrimitives().

Acknowledged.

[Erik Dahlström (inactive), 2015-03-10 15:01:12]

The CQ bit was checked by ed@opera.com

[commit-bot: I haz the power, 2015-03-10 15:02:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/992213002/30009

[commit-bot: I haz the power, 2015-03-10 18:04:47]

Committed patchset #3 (id:30009) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191645