Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 992213002: [S.P.] Move filter painting to SVGFilterPainter. (Closed)

Created:
5 years, 9 months ago by Erik Dahlström (inactive)
Modified:
5 years, 9 months ago
Reviewers:
pdr., fs
CC:
blink-reviews, slimming-paint-reviews_chromium.org, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, Dominik Röttsches, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, blink-reviews-paint_chromium.org, dshwang, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[S.P.] Move filter painting to SVGFilterPainter. BUG=462077 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191645

Patch Set 1 #

Total comments: 9

Patch Set 2 : codereview fixes #

Patch Set 3 : rename setter too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -323 lines) Patch
M Source/core/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGResourceFilter.h View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGResourceFilter.cpp View 1 2 chunks +0 lines, -174 lines 0 comments Download
M Source/core/paint/SVGClipPainter.h View 1 chunk +1 line, -1 line 0 comments Download
A Source/core/paint/SVGFilterPainter.h View 1 chunk +29 lines, -0 lines 0 comments Download
A + Source/core/paint/SVGFilterPainter.cpp View 1 2 5 chunks +21 lines, -140 lines 0 comments Download
M Source/core/paint/SVGMaskPainter.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/SVGPaintContext.cpp View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Erik Dahlström (inactive)
5 years, 9 months ago (2015-03-10 11:30:15 UTC) #2
fs
https://codereview.chromium.org/992213002/diff/1/Source/core/layout/svg/LayoutSVGResourceFilter.cpp File Source/core/layout/svg/LayoutSVGResourceFilter.cpp (right): https://codereview.chromium.org/992213002/diff/1/Source/core/layout/svg/LayoutSVGResourceFilter.cpp#newcode31 Source/core/layout/svg/LayoutSVGResourceFilter.cpp:31: #include "platform/graphics/filters/SourceGraphic.h" Don't think this is needed anymore. https://codereview.chromium.org/992213002/diff/1/Source/core/layout/svg/LayoutSVGResourceFilter.cpp#newcode141 ...
5 years, 9 months ago (2015-03-10 12:12:01 UTC) #3
Erik Dahlström (inactive)
https://codereview.chromium.org/992213002/diff/1/Source/core/layout/svg/LayoutSVGResourceFilter.cpp File Source/core/layout/svg/LayoutSVGResourceFilter.cpp (right): https://codereview.chromium.org/992213002/diff/1/Source/core/layout/svg/LayoutSVGResourceFilter.cpp#newcode31 Source/core/layout/svg/LayoutSVGResourceFilter.cpp:31: #include "platform/graphics/filters/SourceGraphic.h" On 2015/03/10 12:12:01, fs wrote: > Don't ...
5 years, 9 months ago (2015-03-10 14:39:27 UTC) #4
fs
lgtm https://codereview.chromium.org/992213002/diff/1/Source/core/layout/svg/LayoutSVGResourceFilter.cpp File Source/core/layout/svg/LayoutSVGResourceFilter.cpp (right): https://codereview.chromium.org/992213002/diff/1/Source/core/layout/svg/LayoutSVGResourceFilter.cpp#newcode31 Source/core/layout/svg/LayoutSVGResourceFilter.cpp:31: #include "platform/graphics/filters/SourceGraphic.h" On 2015/03/10 14:39:27, Erik Dahlström wrote: ...
5 years, 9 months ago (2015-03-10 14:48:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/992213002/30009
5 years, 9 months ago (2015-03-10 15:02:05 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 18:04:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:30009) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191645

Powered by Google App Engine
This is Rietveld 408576698