tools/dm_flags.py - Issue 992203004: Fix bug in Valgrind flags config.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dm_flags.py

Issue 992203004: Fix bug in Valgrind flags config. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: nanobench too Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/dm_flags.py

diff --git a/tools/dm_flags.py b/tools/dm_flags.py

index 23612428f307b270d26554c20eec78f12576089c..62c93e40c95808b6501b7a2ae870065e8e4e4f1e 100755

--- a/tools/dm_flags.py

+++ b/tools/dm_flags.py

@@ -61,9 +61,9 @@ def get_args(bot):

# PDF + .webp -> jumps depending on uninitialized memory. skia:3505

if 'Valgrind' in bot:

blacklist.extend('pdf _ .webp'.split(' '))

- if 'GPU' in bot:

+ if '_GPU' in bot:

borenet 2015/03/10 14:50:04 Maybe this should be Valgrind_GPU

mtklein 2015/03/10 14:58:02 Done.

args.append('--nocpu')

- elif 'CPU' in bot:

+ elif '_CPU' in bot:

args.append('--nogpu')

if blacklist:

@@ -107,7 +107,7 @@ def self_test():

'Test-Android-Nexus7-Tegra3-Arm7-Release',

'Test-Android-Xoom-Tegra2-Arm7-Release',

'Test-ChromeOS-Alex-GMA3150-x86-Debug',

- 'Test-Ubuntu12-ShuttleA-GTX550Ti-x86_64-Release-Valgrind_CPU',

+ 'Test-Ubuntu14-GCE-NoGPU-x86_64-Release-Valgrind_CPU',

'Test-Ubuntu12-ShuttleA-GTX550Ti-x86_64-Release-Valgrind_GPU',

'Test-Win7-ShuttleA-HD2000-x86-Debug-ANGLE',

]

« no previous file with comments | « tools/dm_flags.json ('k') | tools/nanobench_flags.json » ('j') | no next file with comments »