Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: tools/dm_flags.py

Issue 992203004: Fix bug in Valgrind flags config. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Valgrind_ Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/dm_flags.json ('k') | tools/nanobench_flags.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 2
3 usage = ''' 3 usage = '''
4 Write extra flags to outfile for DM based on the bot name: 4 Write extra flags to outfile for DM based on the bot name:
5 $ python dm_flags.py outfile Test-Mac10.9-MacMini6.2-HD4000-x86_64-Release 5 $ python dm_flags.py outfile Test-Mac10.9-MacMini6.2-HD4000-x86_64-Release
6 Or run self-tests: 6 Or run self-tests:
7 $ python dm_flags.py test 7 $ python dm_flags.py test
8 ''' 8 '''
9 9
10 import inspect 10 import inspect
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 # Drawing SKPs or images into GPU canvases is a New Thing. 54 # Drawing SKPs or images into GPU canvases is a New Thing.
55 # It seems like we're running out of RAM on some Android bots, so start off 55 # It seems like we're running out of RAM on some Android bots, so start off
56 # with a very wide blacklist disabling all these tests on all Android bots. 56 # with a very wide blacklist disabling all these tests on all Android bots.
57 if 'Android' in bot: # skia:3255 57 if 'Android' in bot: # skia:3255
58 blacklist.extend('gpu skp _ gpu image _ gpu subset _'.split(' ')) 58 blacklist.extend('gpu skp _ gpu image _ gpu subset _'.split(' '))
59 blacklist.extend('msaa skp _ msaa image _ gpu subset _'.split(' ')) 59 blacklist.extend('msaa skp _ msaa image _ gpu subset _'.split(' '))
60 60
61 # PDF + .webp -> jumps depending on uninitialized memory. skia:3505 61 # PDF + .webp -> jumps depending on uninitialized memory. skia:3505
62 if 'Valgrind' in bot: 62 if 'Valgrind' in bot:
63 blacklist.extend('pdf _ .webp'.split(' ')) 63 blacklist.extend('pdf _ .webp'.split(' '))
64 if 'GPU' in bot: 64 if 'Valgrind_GPU' in bot:
65 args.append('--nocpu') 65 args.append('--nocpu')
66 elif 'CPU' in bot: 66 elif 'Valgrind_CPU' in bot:
67 args.append('--nogpu') 67 args.append('--nogpu')
68 68
69 if blacklist: 69 if blacklist:
70 args.append('--blacklist') 70 args.append('--blacklist')
71 args.extend(blacklist) 71 args.extend(blacklist)
72 72
73 match = [] 73 match = []
74 if 'Alex' in bot: # skia:2793 74 if 'Alex' in bot: # skia:2793
75 # This machine looks to be running out of heap. 75 # This machine looks to be running out of heap.
76 # Running with fewer threads may help. 76 # Running with fewer threads may help.
(...skipping 23 matching lines...) Expand all
100 cov_end = lineno() # Don't care about code coverage past here. 100 cov_end = lineno() # Don't care about code coverage past here.
101 101
102 102
103 def self_test(): 103 def self_test():
104 import coverage # This way the bots don't need coverage.py to be installed. 104 import coverage # This way the bots don't need coverage.py to be installed.
105 args = {} 105 args = {}
106 cases = [ 106 cases = [
107 'Test-Android-Nexus7-Tegra3-Arm7-Release', 107 'Test-Android-Nexus7-Tegra3-Arm7-Release',
108 'Test-Android-Xoom-Tegra2-Arm7-Release', 108 'Test-Android-Xoom-Tegra2-Arm7-Release',
109 'Test-ChromeOS-Alex-GMA3150-x86-Debug', 109 'Test-ChromeOS-Alex-GMA3150-x86-Debug',
110 'Test-Ubuntu12-ShuttleA-GTX550Ti-x86_64-Release-Valgrind_CPU', 110 'Test-Ubuntu14-GCE-NoGPU-x86_64-Release-Valgrind_CPU',
111 'Test-Ubuntu12-ShuttleA-GTX550Ti-x86_64-Release-Valgrind_GPU', 111 'Test-Ubuntu12-ShuttleA-GTX550Ti-x86_64-Release-Valgrind_GPU',
112 'Test-Win7-ShuttleA-HD2000-x86-Debug-ANGLE', 112 'Test-Win7-ShuttleA-HD2000-x86-Debug-ANGLE',
113 ] 113 ]
114 114
115 cov = coverage.coverage() 115 cov = coverage.coverage()
116 cov.start() 116 cov.start()
117 for case in cases: 117 for case in cases:
118 args[case] = get_args(case) 118 args[case] = get_args(case)
119 cov.stop() 119 cov.stop()
120 120
(...skipping 13 matching lines...) Expand all
134 if len(sys.argv) == 2 and sys.argv[1] == 'test': 134 if len(sys.argv) == 2 and sys.argv[1] == 'test':
135 self_test() 135 self_test()
136 sys.exit(0) 136 sys.exit(0)
137 137
138 if len(sys.argv) != 3: 138 if len(sys.argv) != 3:
139 print usage 139 print usage
140 sys.exit(1) 140 sys.exit(1)
141 141
142 with open(sys.argv[1], 'w') as out: 142 with open(sys.argv[1], 'w') as out:
143 json.dump(get_args(sys.argv[2]), out) 143 json.dump(get_args(sys.argv[2]), out)
OLDNEW
« no previous file with comments | « tools/dm_flags.json ('k') | tools/nanobench_flags.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698