Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 992193002: Remove deprecated CpuProfiler methods (Closed)

Created:
5 years, 9 months ago by yurys
Modified:
5 years, 9 months ago
Reviewers:
Sven Panne, Yang, loislo
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove deprecated CpuProfiler methods BUG=None LOG=Y Committed: https://crrev.com/39d329103f5b5556a3155c736a4ebf582fa18d17 Cr-Commit-Position: refs/heads/master@{#27097}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -30 lines) Patch
M include/v8-profiler.h View 2 chunks +0 lines, -13 lines 0 comments Download
M src/api.cc View 3 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
yurys
5 years, 9 months ago (2015-03-10 09:38:41 UTC) #2
loislo
lgtm
5 years, 9 months ago (2015-03-10 09:42:07 UTC) #3
yurys
Yang or Sven, please take a look.
5 years, 9 months ago (2015-03-10 10:37:47 UTC) #5
Yang
On 2015/03/10 10:37:47, yurys wrote: > Yang or Sven, please take a look. lgtm.
5 years, 9 months ago (2015-03-10 10:38:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/992193002/1
5 years, 9 months ago (2015-03-10 10:51:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-10 11:58:18 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 11:58:33 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/39d329103f5b5556a3155c736a4ebf582fa18d17
Cr-Commit-Position: refs/heads/master@{#27097}

Powered by Google App Engine
This is Rietveld 408576698