Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 992183003: Don't load webstore component for guest session (Closed)

Created:
5 years, 9 months ago by François Beaufort
Modified:
5 years, 9 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't load webstore component for guest session BUG=466040 Committed: https://crrev.com/5770cf0d22db86df181066fff84958b072e32153 Cr-Commit-Position: refs/heads/master@{#321313}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/extensions/component_loader.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
François Beaufort
Hello Ben, As you've read in kuscher email, we shouldn't load WebStore component in Guest ...
5 years, 9 months ago (2015-03-13 11:24:44 UTC) #2
benwells
lgtm, thanks!
5 years, 9 months ago (2015-03-13 22:02:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/992183003/1
5 years, 9 months ago (2015-03-14 07:12:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/18012)
5 years, 9 months ago (2015-03-14 07:58:52 UTC) #7
François Beaufort
Hey Ben, Here's an updated and hopefully saner version of this CL.
5 years, 9 months ago (2015-03-18 13:11:38 UTC) #8
benwells
lgtm
5 years, 9 months ago (2015-03-19 04:12:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/992183003/40001
5 years, 9 months ago (2015-03-19 06:25:12 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-19 08:14:18 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 08:15:14 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5770cf0d22db86df181066fff84958b072e32153
Cr-Commit-Position: refs/heads/master@{#321313}

Powered by Google App Engine
This is Rietveld 408576698