Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 992083002: base: Stop passing by non-const references in some more places. (Closed)

Created:
5 years, 9 months ago by danakj
Modified:
5 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, erikwright+watch_chromium.org, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: Stop passing by non-const references in some more places. These are mostly unit test changes. There are a fair number of occurances still, but they are not easy (or possible) to change due to STL, third_party, or template requirements. R=Nico BUG=464816 Committed: https://crrev.com/9fdfd058a7df48c29dd254d8a6a02c8f7c8d31a1 Cr-Commit-Position: refs/heads/master@{#319812}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -68 lines) Patch
M base/files/file_util_unittest.cc View 13 chunks +14 lines, -14 lines 0 comments Download
M base/json/json_value_serializer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/histogram_tester.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/test/histogram_tester.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M base/threading/thread_collision_warner_unittest.cc View 6 chunks +34 lines, -38 lines 0 comments Download
M base/trace_event/trace_event_impl.cc View 3 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
danakj
5 years, 9 months ago (2015-03-09 22:51:12 UTC) #1
Nico
lgtm
5 years, 9 months ago (2015-03-09 23:15:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/992083002/1
5 years, 9 months ago (2015-03-10 00:27:37 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-10 01:48:15 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 01:49:29 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9fdfd058a7df48c29dd254d8a6a02c8f7c8d31a1
Cr-Commit-Position: refs/heads/master@{#319812}

Powered by Google App Engine
This is Rietveld 408576698