Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 992033002: Change the name of Component.render to Component.build in Effen (Closed)

Created:
5 years, 9 months ago by rafaelw
Modified:
5 years, 9 months ago
Reviewers:
abarth-chromium, ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Change the name of Component.render to Component.build in Effen. "Render" is misleading. "Build" may not be the best word either, it's closer to what's actually happening. R=ojan@chromium.org TBR=abarth BUG= Committed: https://chromium.googlesource.com/external/mojo/+/bc03faa3cf4027730959fc669aced7cf1d5f7100

Patch Set 1 #

Patch Set 2 : README #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -82 lines) Patch
M sky/examples/fn/README.md View 1 4 chunks +15 lines, -15 lines 0 comments Download
M sky/examples/fn/widgets/box.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/fn/widgets/button.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/examples/fn/widgets/checkbox.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/examples/fn/widgets/drawer.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/fn/widgets/drawerheader.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/fn/widgets/fixedheightscrollable.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M sky/examples/fn/widgets/floating_action_button.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/examples/fn/widgets/icon.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/fn/widgets/inksplash.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/fn/widgets/material.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/fn/widgets/menudivider.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/fn/widgets/menuitem.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/examples/fn/widgets/radio.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/examples/fn/widgets/toolbar.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/stocks-fn/stockarrow.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/stocks-fn/stocklist.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/stocks-fn/stockrow.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/examples/stocks-fn/stocksapp.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/fn.dart View 7 chunks +41 lines, -41 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
ojan
lgtm
5 years, 9 months ago (2015-03-09 20:27:47 UTC) #2
rafaelw
5 years, 9 months ago (2015-03-09 20:30:22 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
bc03faa3cf4027730959fc669aced7cf1d5f7100 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698