runtime/vm/flow_graph_optimizer.cc - Issue 99203010: Alternative Timer implementation using simply list-based priority heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 99203010: Alternative Timer implementation using simply list-based priority heap. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Cleanup and fix flow-graph optimizer to not hoist guard fields (works around a VM crash). Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_optimizer.cc

diff --git a/runtime/vm/flow_graph_optimizer.cc b/runtime/vm/flow_graph_optimizer.cc

index a3a6dea9707acf92d7e4090f28c74f6e803e7b52..b0e343ccde7e35bae879f4973445de3f71417e4b 100644

--- a/runtime/vm/flow_graph_optimizer.cc

+++ b/runtime/vm/flow_graph_optimizer.cc

@@ -4398,7 +4398,8 @@ void LICM::Optimize() {

}

if (inputs_loop_invariant &&

!current->IsAssertAssignable() &&

- !current->IsAssertBoolean()) {

+ !current->IsAssertBoolean() &&

+ !current->IsGuardField()) {

Florian Schneider 2013/12/16 12:41:29 Please add TODO(15652): Hoisting guard-field inst

// TODO(fschneider): Enable hoisting of Assert-instructions

// if it safe to do.

Hoist(&it, pre_header, current);

« no previous file with comments | « no previous file | sdk/lib/io/timer_impl.dart » ('j') | no next file with comments »