Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 99203002: Remove TreatNullAs=NullString for HTMLMetaElement (Closed)

Created:
7 years ago by philipj_slow
Modified:
7 years ago
CC:
blink-reviews, kenneth.christiansen, arv+blink, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Remove TreatNullAs=NullString for HTMLMetaElement http://whatwg.org/html#the-meta-element http://whatwg.org/html#HTMLMetaElement-partial The tests for the updated properties pass in Firefox Nightly, IE11 Release Preview and Opera 12.16. BUG=310298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162999

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M LayoutTests/fast/dom/element-attribute-js-null.html View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/dom/element-attribute-js-null-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLMetaElement.idl View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
philipj_slow
7 years ago (2013-12-02 15:10:01 UTC) #1
arv (Not doing code reviews)
LGTM
7 years ago (2013-12-02 15:23:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/99203002/1
7 years ago (2013-12-02 15:31:18 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-02 16:44:43 UTC) #4
Message was sent while issue was closed.
Change committed as 162999

Powered by Google App Engine
This is Rietveld 408576698