Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 991963004: Revert of Adding telemetry test for page scroll using scrollbar drag. (Closed)

Created:
5 years, 9 months ago by ssid
Modified:
5 years, 9 months ago
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Adding telemetry test for page scroll using scrollbar drag. (patchset #4 id:60001 of https://codereview.chromium.org/985603003/) Reason for revert: The test times out. Refer crbug.com/465446 Original issue's description: > Adding telemetry test for page scroll using scrollbar drag. > > This CL adds a telemetry benchmark to use gmail page and uses the > scrollbar and mouss drag action to scroll the page. The test calculates > the mid-point of scrollbar and drags it till the end of the page. > > BUG=464685 > > Committed: https://crrev.com/7b874423d6e08083a2b78cb61f5992c27c92cc2d > Cr-Commit-Position: refs/heads/master@{#319629} TBR=alexclarke@chromium.org,picksi@chromium.org,skyostil@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=464685

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -50 lines) Patch
M tools/perf/page_sets/top_25_smooth.py View 2 chunks +0 lines, -46 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/action_runner.py View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
ssid
Created Revert of Adding telemetry test for page scroll using scrollbar drag.
5 years, 9 months ago (2015-03-09 20:10:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/991963004/1
5 years, 9 months ago (2015-03-09 20:11:56 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-03-09 20:11:58 UTC) #4
Sami
lgtm.
5 years, 9 months ago (2015-03-09 20:12:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/991963004/1
5 years, 9 months ago (2015-03-09 20:13:57 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 20:15:12 UTC) #9
Failed to apply patch for tools/perf/page_sets/top_25_smooth.py:
While running git apply --index -3 -p1;
  error: patch failed: tools/perf/page_sets/top_25_smooth.py:163
  Falling back to three-way merge...
  Applied patch to 'tools/perf/page_sets/top_25_smooth.py' with conflicts.
  U tools/perf/page_sets/top_25_smooth.py

Patch:       tools/perf/page_sets/top_25_smooth.py
Index: tools/perf/page_sets/top_25_smooth.py
diff --git a/tools/perf/page_sets/top_25_smooth.py
b/tools/perf/page_sets/top_25_smooth.py
index
06bcb2483d812e6e451d5324762037ab58c12a10..b19a0bf8b7d5e372870fd61229fd1faa6ae3f408
100644
--- a/tools/perf/page_sets/top_25_smooth.py
+++ b/tools/perf/page_sets/top_25_smooth.py
@@ -51,51 +51,6 @@
     action_runner.ScrollElement(
         element_function='window.__scrollableElementForTelemetry')
     interaction.End()
-
-
-class GmailMouseScrollPage(top_pages.GmailPage):
-
-  """ Why: productivity, top google properties """
-
-  def RunPageInteractions(self, action_runner):
-    action_runner.ExecuteJavaScript('''
-        gmonkey.load('2.0', function(api) {
-          window.__scrollableElementForTelemetry = api.getScrollableElement();
-        });''')
-    action_runner.WaitForJavaScriptCondition(
-        'window.__scrollableElementForTelemetry != null')
-    scrollbar_x, start_y, end_y = self._CalculateScrollBarRatios(action_runner)
-
-    interaction = action_runner.BeginGestureInteraction(
-        'DragAction', is_smooth=True)
-    action_runner.DragPage(left_start_ratio=scrollbar_x,
-        top_start_ratio=start_y, left_end_ratio=scrollbar_x,
-        top_end_ratio=end_y, speed_in_pixels_per_second=100,
-        element_function='window.__scrollableElementForTelemetry')
-    interaction.End()
-
-  def CanRunOnBrowser(self, browser_info):
-    return (browser_info._browser._platform_backend.platform.GetOSName() !=
-        'android')
-
-  def _CalculateScrollBarRatios(self, action_runner):
-    viewport_height = float(action_runner.EvaluateJavaScript(
-        'window.__scrollableElementForTelemetry.clientHeight'))
-    content_height = float(action_runner.EvaluateJavaScript(
-        'window.__scrollableElementForTelemetry.scrollHeight'))
-    viewport_width = float(action_runner.EvaluateJavaScript(
-        'window.__scrollableElementForTelemetry.offsetWidth'))
-    scrollbar_width = float(action_runner.EvaluateJavaScript('''
-        window.__scrollableElementForTelemetry.offsetWidth -
-        window.__scrollableElementForTelemetry.scrollWidth'''))
-
-    # This calculation is correct only when the element doesn't have border or
-    # padding or scroll buttons (eg: gmail mail element).
-    scrollbar_start_mid_y = viewport_height / (2 * content_height)
-    scrollbar_end_mid_y = 1 - scrollbar_start_mid_y
-    scrollbar_mid_x_offset = scrollbar_width / (2 * viewport_width)
-    scrollbar_mid_x = 1 - scrollbar_mid_x_offset
-    return scrollbar_mid_x, scrollbar_start_mid_y, scrollbar_end_mid_y
 
 
 class GoogleCalendarSmoothPage(top_pages.GoogleCalendarPage):
@@ -163,7 +118,6 @@
     self.AddUserStory(_CreatePageClassWithSmoothInteractions(
         top_pages.GoogleWebSearchPage)(self))
     self.AddUserStory(GmailSmoothPage(self))
-    self.AddUserStory(GmailMouseScrollPage(self))
     self.AddUserStory(GoogleCalendarSmoothPage(self))
     self.AddUserStory(_CreatePageClassWithSmoothInteractions(
         top_pages.GoogleImageSearchPage)(self))

Powered by Google App Engine
This is Rietveld 408576698