Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 991963003: Add script to run/test the mojo media renderer. (Closed)

Created:
5 years, 9 months ago by xhwang
Modified:
5 years, 9 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add script to run/test the mojo media renderer. The script follows mojo/services/html_viewer/view_url.py. See the script for how to use it. BUG=410451 TEST=Run the script to test. Committed: https://crrev.com/837e35e1ecd8c4ab62a7011471d56c7b9283fb4d Cr-Commit-Position: refs/heads/master@{#319741}

Patch Set 1 #

Total comments: 4

Patch Set 2 : comments addressed #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -10 lines) Patch
A + media/mojo/scripts/run_mojo_media_renderer.py View 1 2 chunks +25 lines, -10 lines 2 comments Download

Messages

Total messages: 11 (2 generated)
xhwang
PTAL https://codereview.chromium.org/991963003/diff/1/media/mojo/scripts/run_mojo_media_renderer.py File media/mojo/scripts/run_mojo_media_renderer.py (right): https://codereview.chromium.org/991963003/diff/1/media/mojo/scripts/run_mojo_media_renderer.py#newcode39 media/mojo/scripts/run_mojo_media_renderer.py:39: "--vmodule=pipeline*=3,*renderer_impl*=3,*mojo_demuxer*=3") Probably we should make this another parameter ...
5 years, 9 months ago (2015-03-09 18:23:42 UTC) #2
DaleCurtis
https://codereview.chromium.org/991963003/diff/1/media/mojo/scripts/run_mojo_media_renderer.py File media/mojo/scripts/run_mojo_media_renderer.py (right): https://codereview.chromium.org/991963003/diff/1/media/mojo/scripts/run_mojo_media_renderer.py#newcode39 media/mojo/scripts/run_mojo_media_renderer.py:39: "--vmodule=pipeline*=3,*renderer_impl*=3,*mojo_demuxer*=3") On 2015/03/09 18:23:41, xhwang wrote: > Probably we ...
5 years, 9 months ago (2015-03-09 18:29:05 UTC) #3
xhwang
comments addressed
5 years, 9 months ago (2015-03-09 20:02:48 UTC) #4
xhwang
https://codereview.chromium.org/991963003/diff/1/media/mojo/scripts/run_mojo_media_renderer.py File media/mojo/scripts/run_mojo_media_renderer.py (right): https://codereview.chromium.org/991963003/diff/1/media/mojo/scripts/run_mojo_media_renderer.py#newcode39 media/mojo/scripts/run_mojo_media_renderer.py:39: "--vmodule=pipeline*=3,*renderer_impl*=3,*mojo_demuxer*=3") On 2015/03/09 18:29:05, DaleCurtis wrote: > On 2015/03/09 ...
5 years, 9 months ago (2015-03-09 20:03:06 UTC) #5
DaleCurtis
lgtm https://codereview.chromium.org/991963003/diff/20001/media/mojo/scripts/run_mojo_media_renderer.py File media/mojo/scripts/run_mojo_media_renderer.py (right): https://codereview.chromium.org/991963003/diff/20001/media/mojo/scripts/run_mojo_media_renderer.py#newcode64 media/mojo/scripts/run_mojo_media_renderer.py:64: action="store_true") default=False? I forget if you need that.
5 years, 9 months ago (2015-03-09 20:09:44 UTC) #6
xhwang
https://codereview.chromium.org/991963003/diff/20001/media/mojo/scripts/run_mojo_media_renderer.py File media/mojo/scripts/run_mojo_media_renderer.py (right): https://codereview.chromium.org/991963003/diff/20001/media/mojo/scripts/run_mojo_media_renderer.py#newcode64 media/mojo/scripts/run_mojo_media_renderer.py:64: action="store_true") On 2015/03/09 20:09:44, DaleCurtis wrote: > default=False? I ...
5 years, 9 months ago (2015-03-09 20:18:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/991963003/20001
5 years, 9 months ago (2015-03-09 21:11:36 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-09 22:04:31 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 22:05:03 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/837e35e1ecd8c4ab62a7011471d56c7b9283fb4d
Cr-Commit-Position: refs/heads/master@{#319741}

Powered by Google App Engine
This is Rietveld 408576698