Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 991953002: [Closure compiler] Fix extension_error_overlay.js closure compiler (Closed)

Created:
5 years, 9 months ago by Devlin
Modified:
5 years, 9 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Closure compiler] Fix extension_error_overlay.js closure compiler Committed: https://crrev.com/224eb3358720d3b93abc115a3906e6f0fbc3a479 Cr-Commit-Position: refs/heads/master@{#319718}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/extensions/extension_code.js View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 12 (4 generated)
Devlin
5 years, 9 months ago (2015-03-09 17:30:54 UTC) #2
Devlin
https://codereview.chromium.org/991953002/diff/1/chrome/browser/resources/extensions/extension_code.js File chrome/browser/resources/extensions/extension_code.js (right): https://codereview.chromium.org/991953002/diff/1/chrome/browser/resources/extensions/extension_code.js#newcode33 chrome/browser/resources/extensions/extension_code.js:33: * @param {?ExtensionHighlight} code The 'highlight' strings represent the ...
5 years, 9 months ago (2015-03-09 17:35:51 UTC) #3
Dan Beam
lgtm
5 years, 9 months ago (2015-03-09 17:36:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/991953002/1
5 years, 9 months ago (2015-03-09 17:37:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/42749)
5 years, 9 months ago (2015-03-09 17:46:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/991953002/1
5 years, 9 months ago (2015-03-09 17:48:03 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 20:13:59 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 20:14:46 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/224eb3358720d3b93abc115a3906e6f0fbc3a479
Cr-Commit-Position: refs/heads/master@{#319718}

Powered by Google App Engine
This is Rietveld 408576698