Use global GrMemoryPools protected by mutex for GrProcessor/GrBatch

Use global GrMemoryPools protected by mutex for GrProcessor/GrBatch

BUG=chromium:464892
Committed: https://skia.googlesource.com/skia/+/5baedd637806293e9da600af42ada8f75e7db580

[bsalomon, 2015-03-09 17:48:56]

bsalomon@google.com changed reviewers:
+ joshualitt@google.com, mtklein@google.com, robertphillips@google.com

[bsalomon, 2015-03-09 17:49:37]

ptal

[robertphillips, 2015-03-09 17:54:23]

lgtm. Does this "fix" the Chromium failures?

https://codereview.chromium.org/991943002/diff/20001/src/gpu/GrBatch.cpp
File src/gpu/GrBatch.cpp (right):

https://codereview.chromium.org/991943002/diff/20001/src/gpu/GrBatch.cpp#newc...
src/gpu/GrBatch.cpp:11: namespace {
Maybe a comment somewhere explaining why we're doing things this way?

https://codereview.chromium.org/991943002/diff/20001/src/gpu/GrBatch.cpp#newc...
src/gpu/GrBatch.cpp:16: gBatchPoolMutex.acquire();
Why the change from 16384 to 4096?

[bsalomon, 2015-03-09 17:55:12]

https://codereview.chromium.org/991943002/diff/20001/src/gpu/GrBatch.cpp
File src/gpu/GrBatch.cpp (right):

https://codereview.chromium.org/991943002/diff/20001/src/gpu/GrBatch.cpp#newc...
src/gpu/GrBatch.cpp:11: namespace {
On 2015/03/09 17:54:23, robertphillips wrote:
> Maybe a comment somewhere explaining why we're doing things this way?

Will add

https://codereview.chromium.org/991943002/diff/20001/src/gpu/GrBatch.cpp#newc...
src/gpu/GrBatch.cpp:16: gBatchPoolMutex.acquire();
On 2015/03/09 17:54:23, robertphillips wrote:
> Why the change from 16384 to 4096?

copy/paste error from other file. Will fix!

[mtklein, 2015-03-09 18:10:04]

https://codereview.chromium.org/991943002/diff/30001/src/gpu/GrBatch.cpp
File src/gpu/GrBatch.cpp (right):

https://codereview.chromium.org/991943002/diff/30001/src/gpu/GrBatch.cpp#newc...
src/gpu/GrBatch.cpp:12: // threads. The GrContext is not used concurrently on
different threads there is a memory
colon after "threads" (and the other file)?

https://codereview.chromium.org/991943002/diff/30001/src/gpu/GrBatch.cpp#newc...
src/gpu/GrBatch.cpp:21: static SkAutoTDelete<GrMemoryPool>
gPool(SkNEW_ARGS(GrMemoryPool, (16384, 16384)));
Perhaps you can just write

  static GrMemoryPool gPool(16384, 16384);

?  (Similar for the other).

[bsalomon, 2015-03-09 18:42:42]

https://codereview.chromium.org/991943002/diff/30001/src/gpu/GrBatch.cpp
File src/gpu/GrBatch.cpp (right):

https://codereview.chromium.org/991943002/diff/30001/src/gpu/GrBatch.cpp#newc...
src/gpu/GrBatch.cpp:12: // threads. The GrContext is not used concurrently on
different threads there is a memory
On 2015/03/09 18:10:04, mtklein wrote:
> colon after "threads" (and the other file)?

added "and"

https://codereview.chromium.org/991943002/diff/30001/src/gpu/GrBatch.cpp#newc...
src/gpu/GrBatch.cpp:21: static SkAutoTDelete<GrMemoryPool>
gPool(SkNEW_ARGS(GrMemoryPool, (16384, 16384)));
On 2015/03/09 18:10:04, mtklein wrote:
> Perhaps you can just write
> 
>   static GrMemoryPool gPool(16384, 16384);
> 
> ?  (Similar for the other).

Done, moved it to pool(), and removed the member.

[mtklein, 2015-03-09 18:43:54]

lgtm

[bsalomon, 2015-03-09 19:09:19]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-03-09 19:09:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/991943002/#ps50001 (title:
"Address comments")

[commit-bot: I haz the power, 2015-03-09 19:10:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/991943002/50001

[commit-bot: I haz the power, 2015-03-09 19:15:56]

Committed patchset #4 (id:50001) as
https://skia.googlesource.com/skia/+/5baedd637806293e9da600af42ada8f75e7db580