Remove all stuff marked as V8_DEPRECATED.

Remove all stuff marked as V8_DEPRECATED.

R=jochen@chromium.org, mstarzinger@chromium.org, yurys@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=18333

[Sven Panne, 2013-12-02 14:37:40]

Just FYI for now, there are a few things to land first (e.g.
https://codereview.chromium.org/98993002/) until we can land this after the
branch point. More cleanup will be done in this CL, too, e.g. removing the
support for "old" callbacks internally.

[Michael Starzinger, 2013-12-02 15:01:27]

LGTM with a couple of nits.

https://codereview.chromium.org/99193002/diff/1/include/v8.h
File include/v8.h (left):

https://codereview.chromium.org/99193002/diff/1/include/v8.h#oldcode3034
include/v8.h:3034: * A specialization of Value::NumberValue that is more
efficient
Why do we remove this comment, I liked it, can we have it back? Also the empty
new-lines between method declaration make it easier to read IMHO. Same applies
to NumberObject, BooleanObject, StringObject and SymbolObject below.

https://codereview.chromium.org/99193002/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/99193002/diff/1/include/v8.h#newcode1929
include/v8.h:1929: 
nit: Only one empty new-line withing class body.

[Sven Panne, 2013-12-02 17:18:08]

https://codereview.chromium.org/99193002/diff/1/include/v8.h
File include/v8.h (left):

https://codereview.chromium.org/99193002/diff/1/include/v8.h#oldcode3034
include/v8.h:3034: * A specialization of Value::NumberValue that is more
efficient
On 2013/12/02 15:01:28, Michael Starzinger wrote:
> Why do we remove this comment, I liked it, can we have it back?

Hmmm, Value::NumberValue is dead, and I don't like things which can break
without notice. Nevertheless, I don't have any strong feelings about that and I
will update the comment, although I *bet* it will lie again soon...

> Also the empty
> new-lines between method declaration make it easier to read IMHO. Same applies
> to NumberObject, BooleanObject, StringObject and SymbolObject below.

I find it easier to read in their consistent compact form, but again I don't
care about that too much.

https://codereview.chromium.org/99193002/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/99193002/diff/1/include/v8.h#newcode1929
include/v8.h:1929: 
On 2013/12/02 15:01:28, Michael Starzinger wrote:
> nit: Only one empty new-line withing class body.

Doesn't this improve readability? ;-) Will remove that...

[jochen (gone - plz use gerrit), 2013-12-03 10:16:16]

I addressed the TODOs

[Sven Panne, 2013-12-04 11:29:10]

Adding Dan, just to avoid any possibly duplicated work/plans/etc.

Note that this is still work in progress, I'll have to remove the support for
old skool final^H^H^H callbacks.

If there is more stuff to remove (e.g. the tons of "TODO(dcarney) Remove me"),
please yell. If we can remove this cruft without breaking Chrome, I think it's
worthwhile to do it in one big sweep and explain that on v8-users.

[Sven Panne, 2013-12-05 14:44:22]

PTAL again, this is the final version I intend to land after the branch. Added
Yury, perhaps he can take a look at the allocation tracking/debugger changes.

If I missed something which can be removed, please yell. :-)

[jochen (gone - plz use gerrit), 2013-12-05 14:48:01]

https://codereview.chromium.org/99193002/diff/130001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/99193002/diff/130001/include/v8.h#newcode3722
include/v8.h:3722: return GetNativeFunction(name);
plz remove this

[Sven Panne, 2013-12-06 08:04:37]

https://codereview.chromium.org/99193002/diff/130001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/99193002/diff/130001/include/v8.h#newcode3722
include/v8.h:3722: return GetNativeFunction(name);
On 2013/12/05 14:48:01, jochen wrote:
> plz remove this

Done.

[jochen (gone - plz use gerrit), 2013-12-06 08:09:32]

lgtm

[yurys, 2013-12-06 09:38:54]

https://codereview.chromium.org/99193002/diff/170001/include/v8-profiler.h
File include/v8-profiler.h (left):

https://codereview.chromium.org/99193002/diff/170001/include/v8-profiler.h#ol...
include/v8-profiler.h:485: */
These two can be removed not earlier than in V8 v.3.24. So lgtm given that you
are going to land this change after v.3.23 is branched.

[Sven Panne, 2013-12-06 10:24:44]

https://codereview.chromium.org/99193002/diff/170001/include/v8-profiler.h
File include/v8-profiler.h (left):

https://codereview.chromium.org/99193002/diff/170001/include/v8-profiler.h#ol...
include/v8-profiler.h:485: */
On 2013/12/06 09:38:54, yurys wrote:
> These two can be removed not earlier than in V8 v.3.24. So lgtm given that you
> are going to land this change after v.3.23 is branched.

That was the plan: Land this CL after the upcoming branch, probably next week or
so...

[Sven Panne, 2013-12-18 08:09:50]

Committed patchset #14 manually as r18333 (presubmit successful).