Source/modules/accessibility/AXObjectCacheImpl.cpp - Issue 991863003: Avoid unnecessary copies of AccessibilityChildrenVector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXObjectCacheImpl.cpp

Issue 991863003: Avoid unnecessary copies of AccessibilityChildrenVector (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/accessibility/AXObjectCacheImpl.cpp

diff --git a/Source/modules/accessibility/AXObjectCacheImpl.cpp b/Source/modules/accessibility/AXObjectCacheImpl.cpp

index 5ceb4279d55b46a280d55de53c7d1b80e8acad3c..e342b6e49437f3ee5415b1f67786b34d96646c99 100644

--- a/Source/modules/accessibility/AXObjectCacheImpl.cpp

+++ b/Source/modules/accessibility/AXObjectCacheImpl.cpp

@@ -127,7 +127,7 @@ AXObject* AXObjectCacheImpl::focusedImageMapUIElement(HTMLAreaElement* areaEleme

if (!axLayoutImage)

return 0;

- AXObject::AccessibilityChildrenVector imageChildren = axLayoutImage->children();

+ const AXObject::AccessibilityChildrenVector& imageChildren = axLayoutImage->children();

unsigned count = imageChildren.size();

for (unsigned k = 0; k < count; ++k) {

AXObject* child = imageChildren[k].get();

« no previous file with comments | « Source/modules/accessibility/AXObject.cpp ('k') | Source/modules/accessibility/AXTable.cpp » ('j') | no next file with comments »