Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: test/mjsunit/es6/debug-promises/rethrow-in-try-finally.js

Issue 991833002: Simplify promise event on throw handling. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/mjsunit/es6/debug-promises/resolve-after-try-catch.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Flags: --expose-debug-as debug --allow-natives-syntax 5 // Flags: --expose-debug-as debug --allow-natives-syntax
6 6
7 // Test debug events when we only listen to uncaught exceptions and 7 // Test debug events when we listen to all exceptions and
8 // there is a catch handler for the exception thrown in a Promise. 8 // there is a catch handler for the exception thrown in a Promise.
9 // We expect no debug event to be triggered. 9 // We expect a normal Exception debug event to be triggered.
10 10
11 Debug = debug.Debug; 11 Debug = debug.Debug;
12 12
13 var events = [];
14
15 function listener(event, exec_state, event_data, data) {
16 if (event == Debug.DebugEvent.PromiseEvent) events.push(event_data.status());
17 }
18
19 Debug.setListener(listener);
20
13 var p = new Promise(function(resolve, reject) { 21 var p = new Promise(function(resolve, reject) {
22 try {
23 throw new Error("reject");
24 } finally {
25 // Implicit rethrow.
26 }
14 resolve(); 27 resolve();
15 }); 28 });
16 29
17 var q = p.chain( 30 assertEquals([0 /* create */, -1 /* rethrown */], events);
18 function() {
19 throw new Error("caught throw");
20 });
21
22 q.catch(
23 function(e) {
24 assertEquals("caught throw", e.message);
25 });
26
27 function listener(event, exec_state, event_data, data) {
28 try {
29 assertTrue(event != Debug.DebugEvent.Exception);
30 } catch (e) {
31 %AbortJS(e + "\n" + e.stack);
32 }
33 }
34
35 Debug.setBreakOnUncaughtException();
36 Debug.setListener(listener);
OLDNEW
« no previous file with comments | « test/mjsunit/es6/debug-promises/resolve-after-try-catch.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698