Issue 991823003: Use correct TabLaunchType for context menu in Chrome Shell

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 991823003: Use correct TabLaunchType for context menu in Chrome Shell (Closed)

Created:
5 years, 9 months ago by Daniel Imms

Modified:
5 years, 9 months ago

Reviewers:
Bernhard Bauer

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Use correct TabLaunchType for context menu in Chrome Shell Changing TabLaunchType from FROM_LINK to FROM_LONGPRESS_FOREGROUND. This should not have any functionality impact, it's just more correct. BUG=465329 Committed: https://crrev.com/e492d236ddead74d7dd1fda29d56c414d26ccdf2 Cr-Commit-Position: refs/heads/master@{#319626}

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/991823003/1

5 years, 9 months ago (2015-03-09 13:40:55 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-09 14:04:09 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/e492d236ddead74d7dd1fda29d56c414d26ccdf2
Cr-Commit-Position: refs/heads/master@{#319626}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages