Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 991803002: Do not include cached code in the start-up snapshot. (Closed)

Created:
5 years, 9 months ago by Yang
Modified:
5 years, 6 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Do not include cached code in the start-up snapshot. The non-monomorphic cache and the code stub cache contain stubs that are not really useful immediate at start-up. For example we have a lot of RecordWriteStubs for different register combinations. This cuts the start-up snapshot size by another 1/3. R=verwaest@chromium.org

Patch Set 1 #

Patch Set 2 : fix test case #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M src/api.cc View 2 chunks +17 lines, -7 lines 1 comment Download
M test/cctest/test-heap-profiler.cc View 1 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
5 years, 9 months ago (2015-03-09 12:16:19 UTC) #1
Toon Verwaest
5 years, 9 months ago (2015-03-09 12:32:50 UTC) #2
lgtm with comment

https://codereview.chromium.org/991803002/diff/20001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/991803002/diff/20001/src/api.cc#newcode396
src/api.cc:396: *i::UnseededNumberDictionary::New(i_isolate, 128, i::TENURED));
What about extracting the original constructor from CreateInitialObjects() onto
heap somewhere, and calling that? E.g., as ResetCodeCaches();

Powered by Google App Engine
This is Rietveld 408576698