Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1279)

Issue 991793002: Revert of Remove slots that point to unboxed doubles from the StoreBuffer/SlotsBuffer. (patchset #4… (Closed)

Created:
5 years, 9 months ago by Igor Sheludko
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Remove slots that point to unboxed doubles from the StoreBuffer/SlotsBuffer. (patchset #4 id:230001 of https://codereview.chromium.org/957273002/) Reason for revert: It caused a lot of Canary crashes. Original issue's description: > Remove slots that point to unboxed doubles from the StoreBuffer/SlotsBuffer. > > The problem is that tagged slot could become a double slot after migrating of an object to another map with "shifted" fields (for example as a result of generalizing immutable data property to a data field). > This CL also adds useful machinery that helps triggering incremental write barriers. > > BUG=chromium:454297 > LOG=Y > > Committed: https://crrev.com/9633ebabd405c264d33f603f8798c31f59418dcd > Cr-Commit-Position: refs/heads/master@{#27054} TBR=verwaest@chromium.org,hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:454297 Committed: https://crrev.com/67a02321c2e968603c538ab286a6175cdf99b674 Cr-Commit-Position: refs/heads/master@{#27063}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -389 lines) Patch
M src/flag-definitions.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/heap/mark-compact.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/heap/mark-compact.cc View 3 chunks +3 lines, -26 lines 0 comments Download
M src/heap/spaces.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/heap/store-buffer.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/heap/store-buffer.cc View 2 chunks +3 lines, -58 lines 0 comments Download
M src/objects.cc View 3 chunks +4 lines, -61 lines 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 2 chunks +0 lines, -225 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Igor Sheludko
Committed patchset #1 (id:1) manually as 67a02321c2e968603c538ab286a6175cdf99b674.
5 years, 9 months ago (2015-03-09 10:10:54 UTC) #1
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/67a02321c2e968603c538ab286a6175cdf99b674 Cr-Commit-Position: refs/heads/master@{#27063}
5 years, 9 months ago (2015-03-09 10:10:54 UTC) #2
Hannes Payer (out of office)
5 years, 9 months ago (2015-03-09 12:37:16 UTC) #3
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698