Issue 991783006: Fix and suppress some lint warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 991783006: Fix and suppress some lint warnings (Closed)

Created:
5 years, 9 months ago by boliu

Modified:
5 years, 9 months ago

Reviewers:
hush (inactive)

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix and suppress some lint warnings For target android_webview_apk. This only fixes a subset of the issues. BUG= Committed: https://crrev.com/5014cf375daac0746cc4725a3c76e5ff026caa06 Cr-Commit-Position: refs/heads/master@{#319827}

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -11 lines)			Patch
M	android_webview/test/shell/AndroidManifest.xml	View	2 chunks	+8 lines, -9 lines	0 comments	Download
M	android_webview/test/shell/res/layout/testshell_activity.xml	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	android_webview/test/shell/res/values/config.xml	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/991783006/1

5 years, 9 months ago (2015-03-10 01:52:35 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-10 02:46:08 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/5014cf375daac0746cc4725a3c76e5ff026caa06
Cr-Commit-Position: refs/heads/master@{#319827}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages