Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 991753002: [Download] Fix the wrong condition to enable/disable "Resume" menuitem (Closed)

Created:
5 years, 9 months ago by yoshiki
Modified:
5 years, 9 months ago
Reviewers:
asanka
CC:
chromium-reviews, benjhayden+dwatch_chromium.org, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Download] Fix the wrong condition to enable/disable "Resume" menuitem The condition to check the status of "resume" was wrong. This patch fixes it by flipping the condition. BUG=465193 TBR=asanka@chromium.org Committed: https://crrev.com/3ab9636b69a86c98008d7b24dee1dc1ba45179c3 Cr-Commit-Position: refs/heads/master@{#319603}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/download/download_commands.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
yoshiki
Asanka, I found the bug on the previous patch and I'm fixing it with this ...
5 years, 9 months ago (2015-03-09 12:02:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/991753002/1
5 years, 9 months ago (2015-03-09 12:04:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 12:07:21 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3ab9636b69a86c98008d7b24dee1dc1ba45179c3 Cr-Commit-Position: refs/heads/master@{#319603}
5 years, 9 months ago (2015-03-09 12:08:21 UTC) #8
asanka
Please don't land changes without anyone's review. This is also a good reason why we ...
5 years, 9 months ago (2015-03-09 15:15:13 UTC) #9
yoshiki
5 years, 9 months ago (2015-03-09 16:08:29 UTC) #10
Message was sent while issue was closed.
Got it, I'll get an approval before landing in the feature.

And I'm creating an unittest for it and I'll request a review to you soon.
Thanks in advance.

On 2015/03/09 15:15:13, asanka wrote:
> Please don't land changes without anyone's review.
> 
> This is also a good reason why we need tests for DownloadCommands, Could you
> look into that?

Powered by Google App Engine
This is Rietveld 408576698