content/browser/service_worker/service_worker_version_unittest.cc - Issue 991743002: Service Worker: Coalesce the start worker timer into the timeout timer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version_unittest.cc

Issue 991743002: Service Worker: Coalesce the start worker timer into the timeout timer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/service_worker/service_worker_version_unittest.cc

diff --git a/content/browser/service_worker/service_worker_version_unittest.cc b/content/browser/service_worker/service_worker_version_unittest.cc

index cc937fc51b583fde435493f895d074b564759eb5..52c8595028f1a535250130161b8089465dfe596e 100644

--- a/content/browser/service_worker/service_worker_version_unittest.cc

+++ b/content/browser/service_worker/service_worker_version_unittest.cc

@@ -464,8 +464,12 @@ TEST_F(ServiceWorkerFailToStartTest, Timeout) {

EXPECT_EQ(ServiceWorkerVersion::STARTING, version_->running_status());

// Simulate timeout.

- EXPECT_TRUE(version_->start_worker_timeout_timer_.IsRunning());

- version_->start_worker_timeout_timer_.user_task().Run();

+ EXPECT_TRUE(version_->timeout_timer_.IsRunning());

+ version_->start_time_ =

+ base::TimeTicks::Now() -

+ base::TimeDelta::FromMinutes(

+ ServiceWorkerVersion::kStartWorkerTimeoutMinutes + 1);

+ version_->timeout_timer_.user_task().Run();

base::RunLoop().RunUntilIdle();

EXPECT_EQ(SERVICE_WORKER_ERROR_TIMEOUT, status);

EXPECT_EQ(ServiceWorkerVersion::STOPPED, version_->running_status());

« no previous file with comments | « content/browser/service_worker/service_worker_version.cc ('k') | no next file » | no next file with comments »