Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 99173007: Merge 238501 "Attempt to fix audio wedges by restarting all stre..." (Closed)

Created:
7 years ago by DaleCurtis
Modified:
7 years ago
Reviewers:
Dale Curtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Merge 238501 "Attempt to fix audio wedges by restarting all stre..." > Attempt to fix audio wedges by restarting all streams on OSX. > > Introduces two new methods to AudioOutputDispatcher: > CloseStreamsForWedgeFix() and RestartStreamsForWedgeFix(). > > Respectively, each method closes or restarts all active > streams owned by a given dispatcher. The process is > completely transparent to upstream clients. > > A new method on AudioManager, FixWedgedAudio() calls > CloseStreamsForWedgeFix() for all dispatchers and then > calls RestartStreamsForWedgeFix() afterward. > > FixWedgedAudio() is called by each AudioOutputController > when a wedge is detected. Multiple in flight wedge checks > are serialized by the audio thread. The hope is that wedges > will be fixed before the next WedgeCheck() fires. > > While the methods are available on all platforms, FixWedgedAudio() > is only wired up on OSX. > > BUG=160920 > TEST=unittest. fake wedge and observe stream recreation. > R=scherkus@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238325 > > Review URL: https://codereview.chromium.org/61203008 TBR=dalecurtis@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240453

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -0 lines) Patch
M media/audio/audio_manager.h View 1 chunk +5 lines, -0 lines 0 comments Download
M media/audio/audio_manager_base.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/audio/audio_manager_base.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M media/audio/audio_output_controller.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M media/audio/audio_output_dispatcher.h View 1 chunk +7 lines, -0 lines 0 comments Download
M media/audio/audio_output_dispatcher_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M media/audio/audio_output_dispatcher_impl.cc View 2 chunks +19 lines, -0 lines 0 comments Download
M media/audio/audio_output_proxy_unittest.cc View 1 chunk +60 lines, -0 lines 0 comments Download
M media/audio/audio_output_resampler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/audio/audio_output_resampler.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M media/audio/mock_audio_manager.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/audio/mock_audio_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
DaleCurtis
7 years ago (2013-12-12 22:45:24 UTC) #1
DaleCurtis
7 years ago (2013-12-12 22:46:26 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r240453.

Powered by Google App Engine
This is Rietveld 408576698