Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 99173004: Identity API: add multi-account support to token cache and request queues (Closed)

Created:
7 years ago by Michael Courage
Modified:
7 years ago
Reviewers:
Bernhard Bauer, fgorski
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Identity API: add multi-account support to token cache and request queues This change is part of adding chrome.identity.getAccountAndAuthToken. The token cache in IdentityAPI and the IdentityMintRequestQueue both had separate code for tranlating the same API parameters to a lookup key for their internal maps. They now both use ExtensionTokenKey. The ExtensionTokenKey includes an account_id field which will allow its users to support multiple accounts in one profile. All callers currently use the primary account ID, but will be updated in a future change. This change also fixes a bug where getAuthToken would return tokens for the wrong user after switching the account on the profile. BUG=324874, 322284 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238292

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+337 lines, -312 lines) Patch
M chrome/browser/extensions/api/identity/experimental_identity_apitest.cc View 8 chunks +24 lines, -12 lines 0 comments Download
A chrome/browser/extensions/api/identity/extension_token_key.h View 1 chunk +27 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/identity/extension_token_key.cc View 1 chunk +30 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/identity/extension_token_key_unittest.cc View 1 chunk +72 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/identity/identity_api.h View 4 chunks +5 lines, -14 lines 0 comments Download
M chrome/browser/extensions/api/identity/identity_api.cc View 11 chunks +17 lines, -46 lines 0 comments Download
M chrome/browser/extensions/api/identity/identity_apitest.cc View 22 chunks +64 lines, -56 lines 0 comments Download
M chrome/browser/extensions/api/identity/identity_mint_queue.h View 2 chunks +14 lines, -22 lines 0 comments Download
M chrome/browser/extensions/api/identity/identity_mint_queue.cc View 1 chunk +33 lines, -46 lines 0 comments Download
M chrome/browser/extensions/api/identity/identity_mint_queue_unittest.cc View 2 chunks +36 lines, -107 lines 2 comments Download
M chrome/browser/ui/webui/identity_internals_ui.cc View 6 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/identity_internals_ui_browsertest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Michael Courage
fgorski: please look at everything jhawkins: OWNERS for chrome/browser/ui/webui
7 years ago (2013-12-02 19:37:18 UTC) #1
Michael Courage
-jhawkins (vacation) +bauerb
7 years ago (2013-12-02 19:49:05 UTC) #2
Bernhard Bauer
Web UI LGTM
7 years ago (2013-12-02 20:22:59 UTC) #3
fgorski
lgtm https://codereview.chromium.org/99173004/diff/1/chrome/browser/extensions/api/identity/identity_mint_queue_unittest.cc File chrome/browser/extensions/api/identity/identity_mint_queue_unittest.cc (left): https://codereview.chromium.org/99173004/diff/1/chrome/browser/extensions/api/identity/identity_mint_queue_unittest.cc#oldcode95 chrome/browser/extensions/api/identity/identity_mint_queue_unittest.cc:95: TEST(IdentityMintQueueTest, ParallelRequestsForDifferentScopes) { Is that one no longer ...
7 years ago (2013-12-02 20:54:39 UTC) #4
Michael Courage
https://codereview.chromium.org/99173004/diff/1/chrome/browser/extensions/api/identity/identity_mint_queue_unittest.cc File chrome/browser/extensions/api/identity/identity_mint_queue_unittest.cc (left): https://codereview.chromium.org/99173004/diff/1/chrome/browser/extensions/api/identity/identity_mint_queue_unittest.cc#oldcode95 chrome/browser/extensions/api/identity/identity_mint_queue_unittest.cc:95: TEST(IdentityMintQueueTest, ParallelRequestsForDifferentScopes) { On 2013/12/02 20:54:39, Filip Gorski wrote: ...
7 years ago (2013-12-02 21:53:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/courage@chromium.org/99173004/1
7 years ago (2013-12-02 22:20:40 UTC) #6
commit-bot: I haz the power
7 years ago (2013-12-03 03:28:46 UTC) #7
Message was sent while issue was closed.
Change committed as 238292

Powered by Google App Engine
This is Rietveld 408576698