Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Side by Side Diff: src/typing.cc

Issue 99173002: Use constant types to represent the fixed right arg of a MOD. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Add comment. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/type-info.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 553 matching lines...) Expand 10 before | Expand all | Expand 10 after
564 VariableProxy* proxy = expr->expression()->AsVariableProxy(); 564 VariableProxy* proxy = expr->expression()->AsVariableProxy();
565 if (proxy != NULL && proxy->var()->IsStackAllocated()) { 565 if (proxy != NULL && proxy->var()->IsStackAllocated()) {
566 store_.Seq(variable_index(proxy->var()), Effect(expr->bounds())); 566 store_.Seq(variable_index(proxy->var()), Effect(expr->bounds()));
567 } 567 }
568 } 568 }
569 569
570 570
571 void AstTyper::VisitBinaryOperation(BinaryOperation* expr) { 571 void AstTyper::VisitBinaryOperation(BinaryOperation* expr) {
572 // Collect type feedback. 572 // Collect type feedback.
573 Handle<Type> type, left_type, right_type; 573 Handle<Type> type, left_type, right_type;
574 Maybe<int> fixed_right_arg;
575 oracle()->BinaryType(expr->BinaryOperationFeedbackId(), 574 oracle()->BinaryType(expr->BinaryOperationFeedbackId(),
576 &left_type, &right_type, &type, &fixed_right_arg, expr->op()); 575 &left_type, &right_type, &type, expr->op());
577 NarrowLowerType(expr, type); 576 NarrowLowerType(expr, type);
578 NarrowLowerType(expr->left(), left_type); 577 NarrowLowerType(expr->left(), left_type);
579 NarrowLowerType(expr->right(), right_type); 578 NarrowLowerType(expr->right(), right_type);
580 expr->set_fixed_right_arg(fixed_right_arg);
581 if (expr->op() == Token::OR || expr->op() == Token::AND) { 579 if (expr->op() == Token::OR || expr->op() == Token::AND) {
582 expr->left()->RecordToBooleanTypeFeedback(oracle()); 580 expr->left()->RecordToBooleanTypeFeedback(oracle());
583 } 581 }
584 582
585 switch (expr->op()) { 583 switch (expr->op()) {
586 case Token::COMMA: 584 case Token::COMMA:
587 RECURSE(Visit(expr->left())); 585 RECURSE(Visit(expr->left()));
588 RECURSE(Visit(expr->right())); 586 RECURSE(Visit(expr->right()));
589 NarrowType(expr, expr->right()->bounds()); 587 NarrowType(expr, expr->right()->bounds());
590 break; 588 break;
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
735 void AstTyper::VisitModuleUrl(ModuleUrl* module) { 733 void AstTyper::VisitModuleUrl(ModuleUrl* module) {
736 } 734 }
737 735
738 736
739 void AstTyper::VisitModuleStatement(ModuleStatement* stmt) { 737 void AstTyper::VisitModuleStatement(ModuleStatement* stmt) {
740 RECURSE(Visit(stmt->body())); 738 RECURSE(Visit(stmt->body()));
741 } 739 }
742 740
743 741
744 } } // namespace v8::internal 742 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/type-info.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698