Issue 991693002: Revert of use colorfilter instead of imagefilter when possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 991693002: Revert of use colorfilter instead of imagefilter when possible (Closed)

Created:
5 years, 9 months ago by reed2

Modified:
5 years, 9 months ago

Reviewers:
bsalomon, Stephen White, sugoi, senorblanco, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of use colorfilter instead of imagefilter when possible (patchset #6 id:100001 of https://codereview.chromium.org/966233002/) Reason for revert: Lots of PDF failures -- need to investigate Original issue's description: > use colorfilter instead of imagefilter when possible > > big speed win w/ nanobench --match colorfilter_ > > BUG=skia: > TBR= > > Will require rebaselining, so landing temporarily to trigger layouttests. > > Committed: https://skia.googlesource.com/skia/+/f641bd076d29666a5d2a10d5384e4924b0a0e524 TBR=sugoi@google.com,senorblanco@google.com,bsalomon@google.com,reed@google.com,senorblanco@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/1b110d6bf4aebd4452687a8294d222e3d7e1ed38

Created: 5 years, 9 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -45 lines)			Patch
	M	src/core/SkCanvas.cpp	View		6 chunks	+5 lines, -45 lines	0 comments	Download

Total messages: 3 (0 generated)

reed2

Created Revert of use colorfilter instead of imagefilter when possible

5 years, 9 months ago (2015-03-09 01:46:25 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/991693002/1

5 years, 9 months ago (2015-03-09 01:47:07 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-03-09 01:47:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1b110d6bf4aebd4452687a8294d222e3d7e1ed38