Upstream ChromeMobileApplication bits about sync browser initialization

Upstream ChromeMobileApplication bits about sync browser initialization

Adds ChromeCommandLine initialization and also adds APIs about
sync initialization

Committed: https://crrev.com/b0313c5094dfba8a442c7f3d351de31153554c8c
Cr-Commit-Position: refs/heads/master@{#320018}

[Yusuf, 2015-03-10 17:58:38]

yusufo@chromium.org changed reviewers:
+ nyquist@chromium.org, tedchoc@chromium.org

[Yusuf, 2015-03-10 17:58:39]

nyquist@ for base/
tedchoc@ for ChromiumApplication changes

[Yaron, 2015-03-10 19:55:44]

yfriedman@chromium.org changed reviewers:
+ yfriedman@chromium.org

[Yaron, 2015-03-10 19:55:45]

lgtm

(Yusuf messaged me about this CL so I went ahead and reviewed)

https://codereview.chromium.org/991543003/diff/40001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java
(right):

https://codereview.chromium.org/991543003/diff/40001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java:111:
ChromeCommandLineInitUtil.initChromeCommandLine(this);
Please remove ChromeShellApplication's impl of this function now as it's less
powerful than this

https://codereview.chromium.org/991543003/diff/40001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java:240:
protected void initializeGoogleServicesManager() {
Can you add a "TODO(yusufo): Make this private when GoogleServicesManager is
upstreamed" ?

[Yusuf, 2015-03-10 20:00:20]

https://codereview.chromium.org/991543003/diff/40001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java
(right):

https://codereview.chromium.org/991543003/diff/40001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java:111:
ChromeCommandLineInitUtil.initChromeCommandLine(this);
On 2015/03/10 19:55:45, Yaron wrote:
> Please remove ChromeShellApplication's impl of this function now as it's less
> powerful than this

Done.

https://codereview.chromium.org/991543003/diff/40001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java:240:
protected void initializeGoogleServicesManager() {
On 2015/03/10 19:55:45, Yaron wrote:
> Can you add a "TODO(yusufo): Make this private when GoogleServicesManager is
> upstreamed" ?

Done.

[Yusuf, 2015-03-10 20:00:25]

The CQ bit was checked by yusufo@chromium.org

[Yusuf, 2015-03-10 20:00:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
yfriedman@chromium.org
Link to the patchset: https://codereview.chromium.org/991543003/#ps60001 (title:
"Nits after lgtm")

[commit-bot: I haz the power, 2015-03-10 20:01:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/991543003/60001

[commit-bot: I haz the power, 2015-03-10 22:24:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-10 22:24:45]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)

[Yusuf, 2015-03-11 00:14:33]

yusufo@chromium.org changed reviewers:
+ jbudorick@chromium.org

[Yusuf, 2015-03-11 00:14:34]

jbudorick for the added findbugs_exclusion.

This is moved up from the corresponding downstream file.

[Yusuf, 2015-03-11 00:14:43]

The CQ bit was checked by yusufo@chromium.org

[Yusuf, 2015-03-11 00:14:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
yfriedman@chromium.org
Link to the patchset: https://codereview.chromium.org/991543003/#ps80001 (title:
"added findbugs_exclusion")

[commit-bot: I haz the power, 2015-03-11 00:15:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/991543003/80001

[jbudorick, 2015-03-11 00:22:11]

findbugs lgtm

[commit-bot: I haz the power, 2015-03-11 01:25:25]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-03-11 01:26:12]

Patchset 5 (id:??) landed as
https://crrev.com/b0313c5094dfba8a442c7f3d351de31153554c8c
Cr-Commit-Position: refs/heads/master@{#320018}

[sullivan, 2015-03-12 16:26:01]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1001973002/ by sullivan@chromium.org.

The reason for reverting is: This CL broke the chromium perf bots. See
http://crbug.com/466156 and http://crbug.com/466144.

[Yaron, 2015-03-12 16:32:17]

On 2015/03/12 16:26:01, sullivan wrote:
> A revert of this CL (patchset #5 id:80001) has been created in
> https://codereview.chromium.org/1001973002/ by mailto:sullivan@chromium.org.
> 
> The reason for reverting is: This CL broke the chromium perf bots. See
> http://crbug.com/466156 and http://crbug.com/466144.

Hmm. I suspect it's the removal of ChromeShellApplication.initCommandLine
causing ChromeShell to now use the same command line file as chrome. I think
this is an opportunity to further unify the two (which we're trying through
upstreaming) so perhaps we can update Telemetry to not use a different command
line file for ChromeShell. Annie, wdyt?

[sullivan, 2015-03-12 16:44:46]

On 2015/03/12 16:32:17, Yaron wrote:
> On 2015/03/12 16:26:01, sullivan wrote:
> > A revert of this CL (patchset #5 id:80001) has been created in
> > https://codereview.chromium.org/1001973002/ by mailto:sullivan@chromium.org.
> > 
> > The reason for reverting is: This CL broke the chromium perf bots. See
> > http://crbug.com/466156 and http://crbug.com/466144.
> 
> Hmm. I suspect it's the removal of ChromeShellApplication.initCommandLine
> causing ChromeShell to now use the same command line file as chrome. I think
> this is an opportunity to further unify the two (which we're trying through
> upstreaming) so perhaps we can update Telemetry to not use a different command
> line file for ChromeShell. Annie, wdyt?

We'd be happy to update telemetry to use the best command line, would be great
to get a bug filed with label Cr-Tests-Telemetry with details.

In the short term we need to get the bots green though :)