Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Issue 991513002: Sync HTML element interfaces A-B with the spec (Closed)

Created:
5 years, 9 months ago by philipj_slow
Modified:
5 years, 9 months ago
Reviewers:
Mike West
CC:
arv+blink, blink-reviews, blink-reviews-html_chromium.org, Inactive, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, philipj_slow, vivekg_samsung, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sync HTML element interfaces A-B with the spec There are no changes to the generated code except ordering. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191522

Patch Set 1 #

Patch Set 2 : leave HTMLFrameSetElement to https://codereview.chromium.org/980703006/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -19 lines) Patch
M Source/core/html/HTMLAnchorElement.idl View 1 chunk +17 lines, -7 lines 0 comments Download
M Source/core/html/HTMLAppletElement.idl View 2 chunks +5 lines, -1 line 0 comments Download
M Source/core/html/HTMLAreaElement.idl View 1 chunk +9 lines, -2 lines 0 comments Download
M Source/core/html/HTMLAudioElement.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/html/HTMLBRElement.idl View 1 chunk +4 lines, -1 line 0 comments Download
M Source/core/html/HTMLBaseElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLBodyElement.idl View 1 chunk +14 lines, -7 lines 0 comments Download
M Source/core/html/HTMLButtonElement.idl View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
philipj_slow
PTAL. Can you poke someone about HTMLAnchorElement.integrity?
5 years, 9 months ago (2015-03-07 19:21:08 UTC) #2
philipj_slow
leave HTMLFrameSetElement to https://codereview.chromium.org/980703006/
5 years, 9 months ago (2015-03-08 15:48:55 UTC) #3
Mike West
LGTM!
5 years, 9 months ago (2015-03-09 07:22:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/991513002/20001
5 years, 9 months ago (2015-03-09 08:18:08 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 08:20:53 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191522

Powered by Google App Engine
This is Rietveld 408576698