Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 991393002: CrashReportDatabase::Initialize(): use the database path (Closed)

Created:
5 years, 9 months ago by Mark Mentovai
Modified:
5 years, 9 months ago
Reviewers:
Robert Sesek, scottmg
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

CrashReportDatabase::Initialize(): use the database path. Rather than accepting the path to the database’s parent directory, this now accepts the path to the database itself. Using the parent directory proved cumbersome in practice. When testing crashpad_handler with a variety of databases, it is useful to be able to specify --database=/tmp/crashpad_database, --database=/tmp/crashpad_database_2, etc. The old interface required that these directories be created as a separate step, and would put the actual database at /tmp/crashpad_database/Crashpad. This was contrary to the operation of most tools and interfaces, which would only require that /tmp exist and would put the database at /tmp/crashpad_database. TEST=crashpad_client_test R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/7d5e17cd2e31b52a291e332d3358849e4ba6b6a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M client/crash_report_database.h View 1 chunk +1 line, -2 lines 0 comments Download
M client/crash_report_database_mac.mm View 2 chunks +1 line, -3 lines 0 comments Download
M client/crash_report_database_test.cc View 1 chunk +3 lines, -1 line 0 comments Download
M client/crash_report_database_win.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
5 years, 9 months ago (2015-03-10 17:50:54 UTC) #2
Robert Sesek
LGTM
5 years, 9 months ago (2015-03-10 17:55:17 UTC) #3
Mark Mentovai
5 years, 9 months ago (2015-03-10 18:27:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7d5e17cd2e31b52a291e332d3358849e4ba6b6a8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698