Issue 991353003: Cleanup: Put more Themes code behind defined(ENABLE_THEMES).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 991353003: Cleanup: Put more Themes code behind defined(ENABLE_THEMES).

Created:
5 years, 9 months ago by Lei Zhang

Modified:
5 years, 9 months ago

Reviewers:
pkotwicz

CC:
chromium-reviews, tim+watch_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, pvalenzuela+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered, maniscalco+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Cleanup: Put more Themes code behind defined(ENABLE_THEMES).

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -12 lines)			Patch
M	chrome/browser/profiles/off_the_record_profile_impl.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/search/instant_service.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/search/instant_service.cc	View	1	7 chunks	+14 lines, -5 lines	1 comment	Download
M	chrome/browser/search_engines/ui_thread_search_terms_data.cc	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_components_factory_impl.cc	View		4 chunks	+9 lines, -4 lines	0 comments	Download
M	chrome/browser/themes/theme_service.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

pkotwicz

5 years, 9 months ago (2015-03-11 01:02:58 UTC) #3

LGTM with nit

https://codereview.chromium.org/991353003/diff/20001/chrome/browser/search/in...
File chrome/browser/search/instant_service.cc (right):

https://codereview.chromium.org/991353003/diff/20001/chrome/browser/search/in...
chrome/browser/search/instant_service.cc:44: #include "grit/theme_resources.h"
Nit: theme_resources.h should not be in the ifdef. The resource pack has a lot
of things apart from the default theme images.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages