GetDefaultProfile fixit for Chrome OS network & power settings

GetDefaultProfile fixit for Chrome OS network & power settings.

BUG=322682
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241121

[Mr4D (OOO till 08-26), 2013-12-16 18:31:31]

See comments

https://codereview.chromium.org/99133022/diff/1/chrome/browser/chromeos/choos...
File chrome/browser/chromeos/choose_mobile_network_dialog.cc (right):

https://codereview.chromium.org/99133022/diff/1/chrome/browser/chromeos/choos...
chrome/browser/chromeos/choose_mobile_network_dialog.cc:29:
ProfileManager::GetActiveUserProfileOrOffTheRecord(),
GetActiveUserProfile. Please not OrOffTheRecord (it's depricated)

That said - this seems to be a primary user setting (since we only take the
network settings of the primary user)

https://codereview.chromium.org/99133022/diff/1/chrome/browser/chromeos/sim_d...
File chrome/browser/chromeos/sim_dialog_delegate.cc (right):

https://codereview.chromium.org/99133022/diff/1/chrome/browser/chromeos/sim_d...
chrome/browser/chromeos/sim_dialog_delegate.cc:48:
ProfileManager::GetActiveUserProfileOrOffTheRecord(),
Same as above. OrOffTheRecord is depricated and this seems to be a Primary
user's domain.

[Nikita (slow), 2013-12-16 18:42:03]

lgtm

[michaelpg, 2013-12-16 18:48:12]

https://codereview.chromium.org/99133022/diff/1/chrome/browser/chromeos/choos...
File chrome/browser/chromeos/choose_mobile_network_dialog.cc (right):

https://codereview.chromium.org/99133022/diff/1/chrome/browser/chromeos/choos...
chrome/browser/chromeos/choose_mobile_network_dialog.cc:29:
ProfileManager::GetActiveUserProfileOrOffTheRecord(),
On 2013/12/16 18:31:31, Mr4D wrote:
> GetActiveUserProfile. Please not OrOffTheRecord (it's depricated)

Sorry, that's right.

> That said - this seems to be a primary user setting (since we only take the
> network settings of the primary user)

We take the network settings of the primary user but the current plan is to
allow any user to connect to available networks, which is why I chose the active
user profile. So for example, a secondary user could open their tray and click
"Mobile" to see a list of the primary user's mobile networks without having to
switch to the primary user's desktop.

[Mr4D (OOO till 08-26), 2013-12-16 18:51:09]

lgtm

[commit-bot: I haz the power, 2013-12-16 18:53:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaelpg@chromium.org/99133022/40001

[commit-bot: I haz the power, 2013-12-16 20:18:27]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-12-16 21:26:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaelpg@chromium.org/99133022/40001

[commit-bot: I haz the power, 2013-12-16 23:02:27]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-12-16 23:25:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaelpg@chromium.org/99133022/40001

[commit-bot: I haz the power, 2013-12-17 02:44:37]

Change committed as 241121