net/spdy/spdy_frame_builder.h - Issue 991313002: Revert of Rename WriteString to WriteStringPiece16 in SpdyFrameBuilder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_frame_builder.h

Issue 991313002: Revert of Rename WriteString to WriteStringPiece16 in SpdyFrameBuilder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/spdy/spdy_frame_builder.h

diff --git a/net/spdy/spdy_frame_builder.h b/net/spdy/spdy_frame_builder.h

index 2cecd65b50e6a8392cc064d09c414f1489f5b42f..bd709770c702a7e856f635b2f00c3d6aa2aa7d64 100644

--- a/net/spdy/spdy_frame_builder.h

+++ b/net/spdy/spdy_frame_builder.h

@@ -110,7 +110,8 @@

return (WriteBytes(&upper, sizeof(upper)) &&

WriteBytes(&lower, sizeof(lower)));

}

- bool WriteStringPiece16(const base::StringPiece& value);

+ // TODO(hkhalil) Rename to WriteStringPiece16().

+ bool WriteString(const std::string& value);

bool WriteStringPiece32(const base::StringPiece& value);

bool WriteBytes(const void* data, uint32 data_len);

« no previous file with comments | « no previous file | net/spdy/spdy_frame_builder.cc » ('j') | no next file with comments »