IDL compiler: [SpecialWrapFor] interfaces

IDL compiler: [SpecialWrapFor] interfaces

Docs:
https://sites.google.com/a/chromium.org/dev/blink/webidl/blink-idl-extended-attributes#TOC-SpecialWrapFor-i-

BUG=239771
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163200

[haraken, 2013-12-04 08:20:39]

LGTM.

BTW, what's the conclusion of the refactoring of [CustomWrap] and [CustomToV8]?
Did you finish or could we clean it up more?

[Nils Barth (inactive), 2013-12-04 08:23:20]

On 2013/12/04 08:20:39, haraken wrote:
> LGTM.

Thanks!

> BTW, what's the conclusion of the refactoring of [CustomWrap] and
[CustomToV8]?
> Did you finish or could we clean it up more?

I'm done with the substantive refactoring; the main cleanup was removing
overlapping extended attributes.
Style-wise, I plan to merge [Custom*] on interfaces to:
[Custom=LegacyCall|ToV8|VisitDOMWrapper|Wrap]
...but I'm waiting for the [CustomToV8] CL to land first.

[commit-bot: I haz the power, 2013-12-04 08:23:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/99123003/40001

[commit-bot: I haz the power, 2013-12-04 10:04:33]

Failed to apply patch for Source/bindings/templates/interface.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/templates/interface.cpp
  Hunk #1 FAILED at 449.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/bindings/templates/interface.cpp.rej

Patch:       Source/bindings/templates/interface.cpp
Index: Source/bindings/templates/interface.cpp
diff --git a/Source/bindings/templates/interface.cpp
b/Source/bindings/templates/interface.cpp
index
4a982fec6532564562c580cbd7c4498f2079b462..115c977fe337d5d7a7aea16f26b6d85e9507a4f3
100644
--- a/Source/bindings/templates/interface.cpp
+++ b/Source/bindings/templates/interface.cpp
@@ -449,6 +449,24 @@ ActiveDOMObject*
{{v8_class}}::toActiveDOMObject(v8::Handle<v8::Object> wrapper)
 
 

{##############################################################################}
+{% block wrap %}
+{% if special_wrap_for %}
+v8::Handle<v8::Object> wrap({{cpp_class}}* impl, v8::Handle<v8::Object>
creationContext, v8::Isolate* isolate)
+{
+    ASSERT(impl);
+    {% for special_wrap_interface in special_wrap_for %}
+    if (impl->is{{special_wrap_interface}}())
+        return wrap(to{{special_wrap_interface}}(impl), creationContext,
isolate);
+    {% endfor %}
+    v8::Handle<v8::Object> wrapper = {{v8_class}}::createWrapper(impl,
creationContext, isolate);
+    return wrapper;
+}
+
+{% endif %}
+{% endblock %}
+
+
+{##############################################################################}
 {% block create_wrapper_and_deref_object %}
 v8::Handle<v8::Object> {{v8_class}}::createWrapper(PassRefPtr<{{cpp_class}}>
impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
 {

[commit-bot: I haz the power, 2013-12-05 01:21:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/99123003/60001

[commit-bot: I haz the power, 2013-12-05 01:21:49]

Change committed as 163200