Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 99103002: Remove TreatNullAs=NullString for various HTML elements (Closed)

Created:
7 years ago by philipj_slow
Modified:
7 years ago
CC:
blink-reviews, adamk+blink_chromium.org, dglazkov+blink, arv+blink, Inactive, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Remove TreatNullAs=NullString for various HTML elements http://whatwg.org/html#htmllabelelement http://whatwg.org/html#HTMLLegendElement-partial http://whatwg.org/html#htmlmapelement http://whatwg.org/html#htmloptgroupelement http://whatwg.org/html#htmlstyleelement http://whatwg.org/html#htmltitleelement The tests for the updated properties pass in Firefox Nightly, IE11 Release Preview and Opera 12.16, with these exceptions: IE throws an exception for HTMLLegendElement.align. BUG=310298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163009

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -27 lines) Patch
M LayoutTests/fast/dom/element-attribute-js-null.html View 6 chunks +7 lines, -7 lines 0 comments Download
M LayoutTests/fast/dom/element-attribute-js-null-expected.txt View 5 chunks +7 lines, -7 lines 0 comments Download
M Source/core/html/HTMLLabelElement.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/HTMLLegendElement.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/HTMLMapElement.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/HTMLOptGroupElement.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/HTMLStyleElement.idl View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/html/HTMLTitleElement.idl View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
philipj_slow
7 years ago (2013-12-02 14:27:53 UTC) #1
arv (Not doing code reviews)
LGTM
7 years ago (2013-12-02 15:02:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/99103002/1
7 years ago (2013-12-02 15:10:03 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-02 18:01:12 UTC) #4
Message was sent while issue was closed.
Change committed as 163009

Powered by Google App Engine
This is Rietveld 408576698