Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 991013002: Combine clips in content target space. (Closed)

Created:
5 years, 9 months ago by Ian Vollick
Modified:
5 years, 9 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Combine clips in content target space. We currently combine clips in the target space of the clip's transform node. This is incorrect. We want to combine clips in the space of the transform node's _content_ target space. BUG=386810 Committed: https://crrev.com/67394b4da49066bdea3d1dfea69e063a9060920d Cr-Commit-Position: refs/heads/master@{#319789}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -1 line) Patch
M cc/trees/draw_property_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ian Vollick
5 years, 9 months ago (2015-03-09 20:44:31 UTC) #2
enne (OOO)
lgtm I think I have some quibbles about content_target_id vs target_id now that I understand ...
5 years, 9 months ago (2015-03-09 21:44:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/991013002/1
5 years, 9 months ago (2015-03-09 22:33:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-10 00:22:43 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 00:23:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67394b4da49066bdea3d1dfea69e063a9060920d
Cr-Commit-Position: refs/heads/master@{#319789}

Powered by Google App Engine
This is Rietveld 408576698