Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 990993004: Sync HTML element interfaces H-K with the spec (Closed)

Created:
5 years, 9 months ago by philipj_slow
Modified:
5 years, 9 months ago
Reviewers:
Jens Widell
CC:
blink-reviews, arv+blink, vivekg_samsung, blink-reviews-html_chromium.org, vivekg, dglazkov+blink, Inactive
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Sync HTML element interfaces H-K with the spec In the HTMLInputElement interface some comments documenting the change history were removed. The link for the value attribute was added in https://trac.webkit.org/changeset/134538 to document an #ifdef at the time, but that is no longer needed. No observable changes are intended. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191601

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -54 lines) Patch
M Source/core/html/HTMLHRElement.idl View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/html/HTMLHeadElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLHeadingElement.idl View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/html/HTMLHtmlElement.idl View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/html/HTMLIFrameElement.idl View 1 chunk +22 lines, -16 lines 0 comments Download
M Source/core/html/HTMLImageElement.idl View 1 chunk +26 lines, -17 lines 0 comments Download
M Source/core/html/HTMLInputElement.idl View 3 chunks +27 lines, -20 lines 0 comments Download
M Source/core/html/HTMLKeygenElement.idl View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
philipj_slow
PTAL
5 years, 9 months ago (2015-03-09 19:08:39 UTC) #2
Jens Widell
LGTM
5 years, 9 months ago (2015-03-09 19:19:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990993004/1
5 years, 9 months ago (2015-03-10 03:48:52 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 03:51:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191601

Powered by Google App Engine
This is Rietveld 408576698