Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(905)

Issue 990993003: Remove third-party VPN combined name (Closed)

Created:
5 years, 9 months ago by bartfab (slow)
Modified:
5 years, 9 months ago
Reviewers:
stevenjb, kaliamoorthi
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@f_1_407541_add_vpn_delegate
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove third-party VPN combined name VpnService concatenates the third-party VPN provider's extension name and the user-provided configuration name into a combined name in a non-18n-aware manner. This CL removes the concatenation. The extension name and configuration name will be combined visually by the UI as required instead. BUG=434711, 460428 TEST=Manual, together with follow-up CLs that wire up the UI Committed: https://crrev.com/6f0fab6a683eae9ca05bc69fabe32624d2ce86f6 Cr-Commit-Position: refs/heads/master@{#319870}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -19 lines) Patch
M extensions/browser/api/vpn_provider/vpn_service.cc View 4 chunks +4 lines, -19 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
bartfab (slow)
Hi Prabhu, Could you please review?
5 years, 9 months ago (2015-03-09 18:48:51 UTC) #2
stevenjb
lgtm
5 years, 9 months ago (2015-03-09 23:22:10 UTC) #4
kaliamoorthi
On 2015/03/09 23:22:10, stevenjb wrote: > lgtm LGTM
5 years, 9 months ago (2015-03-10 09:03:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990993003/1
5 years, 9 months ago (2015-03-10 12:49:55 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-10 13:19:42 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 13:20:31 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f0fab6a683eae9ca05bc69fabe32624d2ce86f6
Cr-Commit-Position: refs/heads/master@{#319870}

Powered by Google App Engine
This is Rietveld 408576698