Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 990983002: Revert "Revert of Output closure-compiled JavaScript files (patchset #10 id:180001 of https://coder… (Closed)

Created:
5 years, 9 months ago by Theresa
Modified:
5 years, 9 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Revert of Output closure-compiled JavaScript files (patchset #10 id:180001 of https://codereview.chromium.org/958383003/)" This reverts commit 30fc31d16b0d87a21ef7f66f4bd676245180a719. Missed a renaming a reference to run_js_check Original issue's description: > Output closure-compiled JavaScript files > > If generate_output is set, chcker.py adds compiler flags to actually > output the compiled JS. It will also output a source map if the build > is Debug. > BUG=393874 Committed: https://crrev.com/aff4f003a28c9b4bd9925dc064c544e4f5208d55 Cr-Commit-Position: refs/heads/master@{#319685}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -12 lines) Patch
M third_party/closure_compiler/checker.py View 8 chunks +22 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Theresa
Fixed the compilation error
5 years, 9 months ago (2015-03-09 16:48:49 UTC) #2
Dan Beam
lgtm
5 years, 9 months ago (2015-03-09 17:59:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990983002/1
5 years, 9 months ago (2015-03-09 18:00:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 18:09:05 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 18:09:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aff4f003a28c9b4bd9925dc064c544e4f5208d55
Cr-Commit-Position: refs/heads/master@{#319685}

Powered by Google App Engine
This is Rietveld 408576698