src/x64/lithium-codegen-x64.cc - Issue 990963003: [turbofan] Unify Math.floor / Math.ceil optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-codegen-x64.cc

Issue 990963003: [turbofan] Unify Math.floor / Math.ceil optimization. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/lithium-codegen-x64.cc

diff --git a/src/x64/lithium-codegen-x64.cc b/src/x64/lithium-codegen-x64.cc

index 6dde8a309ff754df1b498ac3b42b6036901422cd..c95742588d5778206e03b3936ce596f595dbba1b 100644

--- a/src/x64/lithium-codegen-x64.cc

+++ b/src/x64/lithium-codegen-x64.cc

@@ -3766,7 +3766,7 @@ void LCodeGen::DoMathFloor(LMathFloor* instr) {

__ subq(output_reg, Immediate(1));

DeoptimizeIf(overflow, instr, Deoptimizer::kMinusZero);

}

- __ roundsd(xmm_scratch, input_reg, Assembler::kRoundDown);

+ __ roundsd(xmm_scratch, input_reg, kRoundDown);

__ cvttsd2si(output_reg, xmm_scratch);

__ cmpl(output_reg, Immediate(0x1));

DeoptimizeIf(overflow, instr, Deoptimizer::kOverflow);

« no previous file with comments | « src/x64/assembler-x64.cc ('k') | test/cctest/compiler/test-run-machops.cc » ('j') | no next file with comments »