Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 990943003: Add Cast() to Boolean (Closed)

Created:
5 years, 9 months ago by bashi
Modified:
5 years, 9 months ago
Reviewers:
dcarney
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add Cast() to Boolean We should be able to cast a Value to Boolean when IsBoolean() is true. Committed: https://crrev.com/8bdac106312c88e2f3059efa067ebbbfc7467360 Cr-Commit-Position: refs/heads/master@{#27124}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M include/v8.h View 2 chunks +11 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bashi
I need this to fix the compile error which occurred when I trying to use ...
5 years, 9 months ago (2015-03-10 05:35:41 UTC) #2
dcarney
lgtm On 2015/03/10 05:35:41, bashi1 wrote: > I need this to fix the compile error ...
5 years, 9 months ago (2015-03-10 08:05:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990943003/1
5 years, 9 months ago (2015-03-10 23:11:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-10 23:40:23 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 23:40:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8bdac106312c88e2f3059efa067ebbbfc7467360
Cr-Commit-Position: refs/heads/master@{#27124}

Powered by Google App Engine
This is Rietveld 408576698