Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 990913002: RTCVideoDecoder: Using I420VideoFrame directly instead of to-be-removed TextureVideoFrame (previous… (Closed)

Created:
5 years, 9 months ago by hbos_chromium
Modified:
5 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

RTCVideoDecoder: Using I420VideoFrame directly instead of to-be-removed TextureVideoFrame (previously this typeddefed to I420VideoFrame). BUG=webrtc:1128 Committed: https://crrev.com/f5c7c4790e808d0f1c97b75ae10fb008659ecd02 Cr-Commit-Position: refs/heads/master@{#319652}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M content/renderer/media/rtc_video_decoder.cc View 2 chunks +6 lines, -6 lines 1 comment Download

Messages

Total messages: 12 (4 generated)
magjed_chromium
lgtm https://codereview.chromium.org/990913002/diff/1/content/renderer/media/rtc_video_decoder.cc File content/renderer/media/rtc_video_decoder.cc (right): https://codereview.chromium.org/990913002/diff/1/content/renderer/media/rtc_video_decoder.cc#newcode21 content/renderer/media/rtc_video_decoder.cc:21: #include "third_party/webrtc/common_video/interface/i420_video_frame.h" I think you should use "webrtc/video_frame.h" ...
5 years, 9 months ago (2015-03-09 13:20:25 UTC) #2
hbos_chromium
I'm not changing the #include because that led to "You added one or more #includes ...
5 years, 9 months ago (2015-03-09 13:29:56 UTC) #4
hbos_chromium
5 years, 9 months ago (2015-03-09 13:53:58 UTC) #6
tommi (sloooow) - chröme
Can you add a bug reference? E.g. BUG=webrtc:1128
5 years, 9 months ago (2015-03-09 13:58:17 UTC) #7
tommi (sloooow) - chröme
other than that, lgtm.
5 years, 9 months ago (2015-03-09 13:58:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990913002/1
5 years, 9 months ago (2015-03-09 15:09:52 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 16:37:57 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 16:38:51 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f5c7c4790e808d0f1c97b75ae10fb008659ecd02
Cr-Commit-Position: refs/heads/master@{#319652}

Powered by Google App Engine
This is Rietveld 408576698