Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 990903008: MIPS: Remove code object from StackHandler. (Closed)

Created:
5 years, 9 months ago by balazs.kilvady
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Remove code object from StackHandler. Port e0aa8ebf933b4c659e1c4a01ba244c5de452ff1c Original commit message: This reduces the size of the StackHandler by one word. We no longer need to keep track of the code object, as the stack walk finds it. BUG= Committed: https://crrev.com/fd012f1080eb8fccdefe64ff854abf2852943d56 Cr-Commit-Position: refs/heads/master@{#27120}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -19 lines) Patch
M src/mips/macro-assembler-mips.cc View 1 chunk +8 lines, -10 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +8 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
balazs.kilvady
5 years, 9 months ago (2015-03-10 17:27:02 UTC) #2
Michael Starzinger
LGTM.
5 years, 9 months ago (2015-03-10 17:44:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990903008/1
5 years, 9 months ago (2015-03-10 18:08:25 UTC) #5
paul.l...
Also LGTM ....
5 years, 9 months ago (2015-03-10 18:10:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-10 19:07:21 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 19:07:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd012f1080eb8fccdefe64ff854abf2852943d56
Cr-Commit-Position: refs/heads/master@{#27120}

Powered by Google App Engine
This is Rietveld 408576698