test/cctest/test-heap-profiler.cc - Issue 990883002: Hide Math function implementations in a closure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-heap-profiler.cc

Issue 990883002: Hide Math function implementations in a closure. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-heap-profiler.cc

diff --git a/test/cctest/test-heap-profiler.cc b/test/cctest/test-heap-profiler.cc

index a26edd5358f45c7f5707b225b3f9cd47e65e3abd..4c2ac10a306dc740a9515cf6c386f632f760124e 100644

--- a/test/cctest/test-heap-profiler.cc

+++ b/test/cctest/test-heap-profiler.cc

@@ -2379,12 +2379,8 @@ TEST(CheckCodeNames) {

heap_profiler->TakeHeapSnapshot(v8_str("CheckCodeNames"));

CHECK(ValidateSnapshot(snapshot));

- const char* stub_path[] = {

- "::(GC roots)",

- "::(Strong roots)",

- "code_stubs::",

- "::(ArraySingleArgumentConstructorStub code)"

- };

+ const char* stub_path[] = {"::(GC roots)", "::(Strong roots)", "code_stubs::",

+ "::(CEntryStub code)"};

const v8::HeapGraphNode* node = GetNodeByPath(snapshot,

stub_path, arraysize(stub_path));

CHECK(node);