Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 990883002: Hide Math function implementations in a closure. (Closed)

Created:
5 years, 9 months ago by Yang
Modified:
5 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Hide Math function implementations in a closure. R=jkummerow@chromium.org Committed: https://crrev.com/67bc45c27856364a23f155e0b2966809c34dc2ab Cr-Commit-Position: refs/heads/master@{#27072}

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove printf and unnecessary test case change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -114 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M src/array.js View 1 chunk +1 line, -1 line 0 comments Download
M src/arraybuffer.js View 1 chunk +4 lines, -4 lines 0 comments Download
M src/date.js View 2 chunks +3 lines, -3 lines 0 comments Download
M src/harmony-string.js View 3 chunks +3 lines, -3 lines 0 comments Download
M src/json.js View 1 chunk +1 line, -1 line 0 comments Download
M src/macros.py View 1 chunk +0 lines, -1 line 0 comments Download
M src/math.js View 3 chunks +77 lines, -78 lines 0 comments Download
M src/third_party/fdlibm/fdlibm.js View 10 chunks +31 lines, -12 lines 0 comments Download
M src/typedarray.js View 1 chunk +4 lines, -4 lines 0 comments Download
M src/v8natives.js View 2 chunks +1 line, -5 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
5 years, 9 months ago (2015-03-09 12:16:06 UTC) #1
Jakob Kummerow
LGTM with nit. https://codereview.chromium.org/990883002/diff/1/src/snapshot-common.cc File src/snapshot-common.cc (right): https://codereview.chromium.org/990883002/diff/1/src/snapshot-common.cc#newcode169 src/snapshot-common.cc:169: printf("%d %d\n", startup_length, context_length); debugging leftover?
5 years, 9 months ago (2015-03-09 12:29:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990883002/20001
5 years, 9 months ago (2015-03-09 12:54:18 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-09 13:25:40 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 13:25:50 UTC) #6
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/67bc45c27856364a23f155e0b2966809c34dc2ab
Cr-Commit-Position: refs/heads/master@{#27072}

Powered by Google App Engine
This is Rietveld 408576698