Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Issue 990873002: add V8_DEPRECATE_SOON macros to make it easier to identify calls which need deprecation (Closed)

Created:
5 years, 9 months ago by dcarney
Modified:
5 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

add V8_DEPRECATE_SOON macros to make it easier to identify calls which need deprecation BUG= R=svenpanne@chromium.org Committed: https://crrev.com/47154aa8b2564ccb72e233a6c3c449c8edb53001 Cr-Commit-Position: refs/heads/master@{#27061}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -192 lines) Patch
M include/v8.h View 1 39 chunks +197 lines, -192 lines 0 comments Download
M include/v8config.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Sven Panne
lgtm
5 years, 9 months ago (2015-03-09 09:22:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990873002/20001
5 years, 9 months ago (2015-03-09 09:23:35 UTC) #4
commit-bot: I haz the power
Failed to apply the patch.
5 years, 9 months ago (2015-03-09 09:46:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990873002/20001
5 years, 9 months ago (2015-03-09 09:48:35 UTC) #9
commit-bot: I haz the power
Failed to apply the patch.
5 years, 9 months ago (2015-03-09 09:48:49 UTC) #11
dcarney
Committed patchset #2 (id:20001) manually as 47154aa8b2564ccb72e233a6c3c449c8edb53001 (presubmit successful).
5 years, 9 months ago (2015-03-09 09:49:34 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 09:49:37 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/47154aa8b2564ccb72e233a6c3c449c8edb53001
Cr-Commit-Position: refs/heads/master@{#27061}

Powered by Google App Engine
This is Rietveld 408576698