Source/bindings/tests/results/V8TestNode.cpp - Issue 99083002: WIP: Migrate generated bindings to new ExceptionState constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestNode.cpp

Issue 99083002: WIP: Migrate generated bindings to new ExceptionState constructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Feedback. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp ('k') | Source/bindings/tests/results/V8TestObject.cpp » ('j') | Source/bindings/tests/results/V8TestObjectPython.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestNode.cpp

diff --git a/Source/bindings/tests/results/V8TestNode.cpp b/Source/bindings/tests/results/V8TestNode.cpp

index 17fcb34be65546bafc2e1261ea189745531a2726..5453a08d2c562cd846c5ba6c5324b92973b0731e 100644

--- a/Source/bindings/tests/results/V8TestNode.cpp

+++ b/Source/bindings/tests/results/V8TestNode.cpp

@@ -117,9 +117,9 @@ static void hrefThrowsAttributeGetterCallback(v8::Local<v8::String>, const v8::P

static void hrefThrowsAttributeSetter(v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)

{

+ ExceptionState exceptionState(ExceptionState::SetterContext, "hrefThrows", "TestNode", info.Holder(), info.GetIsolate());

TestNode* imp = V8TestNode::toNative(info.Holder());

V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, cppValue, jsValue);

- ExceptionState exceptionState(info.Holder(), info.GetIsolate());

imp->setHrefThrows(cppValue, exceptionState);

exceptionState.throwIfNeeded();

}