WIP: Migrate generated bindings to new ExceptionState constructor.

LayoutTests/fast/events/message-port-clone.html

Index: LayoutTests/fast/events/message-port-clone.html
diff --git a/LayoutTests/fast/events/message-port-clone.html b/LayoutTests/fast/events/message-port-clone.html
index 02f81c8714f90ffca0ead132f0fab013e1ff347d..b738887c39dac0ee28e5e7149b694e40b1022833 100644
--- a/LayoutTests/fast/events/message-port-clone.html
+++ b/LayoutTests/fast/events/message-port-clone.html
@@ -19,14 +19,14 @@ debug("Posting port to entangled pair neuters the port and does nothing else:");
 channel = new MessageChannel;
 var channel2 = new MessageChannel;
 channel.port1.postMessage("msg", [channel.port2]);
-shouldThrow("channel2.port1.postMessage('msg', [channel.port2])", '"DataCloneError: Failed to execute \'disentanglePorts\' on \'MessagePort\': Item #0 in the array of ports is already neutered."');
+shouldThrow("channel2.port1.postMessage('msg', [channel.port2])", '"DataCloneError: Failed to execute \'postMessage\' on \'MessagePort\': Item #0 in the array of ports is already neutered."');

[sof, 2013/12/03 16:04:29]

Can't we just do away with the duplication of exception message here & keep it
in -expected.txt only? If so, deprecating/remvoing shouldThrow()'s 2nd argument
could be handled in a later CL.

[Mike West, 2013/12/04 08:42:19]

It's valuable to have a test fail if the exception's text unexpectedly changes,
and it's very easy to overlook changes if the line of the expectation file still
reads PASS. That said, testing the text on every thrown exception is massive
overkill, and a pain in the ass for cleanup CLs like this one.

I'd like to get to a place where we have one and only one of these two-argument
'shouldThrow()' assertions for each exception we throw. We're not there yet.
Until we are, I'd prefer to keep the two-argument 'shouldThrow()' calls (but I'd
gladly review CLs that set up some sort of "canonical thrown exception" check
and removed the text expectation from other instances.

+arv, who has opinions.

 
 channel = new MessageChannel;
 channel2 = new MessageChannel
 channel.port1.postMessage("msg", [channel2.port1]);
 
 // Should not be able to post a cloned port.
-shouldThrow("channel.port1.postMessage('msg', [channel2.port1])", '"DataCloneError: Failed to execute \'disentanglePorts\' on \'MessagePort\': Item #0 in the array of ports is already neutered."');
+shouldThrow("channel.port1.postMessage('msg', [channel2.port1])", '"DataCloneError: Failed to execute \'postMessage\' on \'MessagePort\': Item #0 in the array of ports is already neutered."');
 
 // Test posting messages to a port in cloned state.