Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: Source/bindings/tests/results/V8SupportTestInterface.cpp

Issue 99083002: WIP: Migrate generated bindings to new ExceptionState constructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: MessagePort. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8SupportTestInterface.cpp
diff --git a/Source/bindings/tests/results/V8SupportTestInterface.cpp b/Source/bindings/tests/results/V8SupportTestInterface.cpp
index e94efb2047816d3ca93993a1e7e8acf2d4f31a72..fa2b441df78daf8fd16d31a9c20643fe7d449569 100644
--- a/Source/bindings/tests/results/V8SupportTestInterface.cpp
+++ b/Source/bindings/tests/results/V8SupportTestInterface.cpp
@@ -113,6 +113,7 @@ static void supplementalStaticAttrAttributeGetterCallback(v8::Local<v8::String>,
#if ENABLE(Condition11) || ENABLE(Condition12)
static void supplementalStaticAttrAttributeSetter(v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)
{
+ ExceptionState exceptionState(ExceptionState::SetterContext, "supplementalStaticAttr", "SupportTestInterface", info.Holder(), info.GetIsolate());
sof 2013/12/03 16:04:29 Unused? Seems a pity to stack allocate these if no
Mike West 2013/12/04 08:42:19 Hrm. Yes, we used to have checks to create the obj
V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, cppValue, jsValue);
SupportTestPartialInterface::setSupplementalStaticAttr(cppValue);
}
@@ -164,6 +165,7 @@ static void supplementalStr2AttributeGetterCallback(v8::Local<v8::String>, const
#if ENABLE(Condition11) || ENABLE(Condition12)
static void supplementalStr2AttributeSetter(v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)
{
+ ExceptionState exceptionState(ExceptionState::SetterContext, "supplementalStr2", "SupportTestInterface", info.Holder(), info.GetIsolate());
SupportTestInterface* imp = V8SupportTestInterface::toNative(info.Holder());
V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, cppValue, jsValue);
SupportTestPartialInterface::setSupplementalStr2(imp, cppValue);
@@ -217,6 +219,7 @@ static void supplementalNodeAttributeGetterCallback(v8::Local<v8::String>, const
#if ENABLE(Condition11) || ENABLE(Condition12)
static void supplementalNodeAttributeSetter(v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)
{
+ ExceptionState exceptionState(ExceptionState::SetterContext, "supplementalNode", "SupportTestInterface", info.Holder(), info.GetIsolate());
SupportTestInterface* imp = V8SupportTestInterface::toNative(info.Holder());
V8TRYCATCH_VOID(Node*, cppValue, V8Node::hasInstance(jsValue, info.GetIsolate(), worldType(info.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(jsValue)) : 0);
SupportTestPartialInterface::setSupplementalNode(imp, WTF::getPtr(cppValue));
@@ -252,6 +255,7 @@ static void Node13AttributeGetterCallback(v8::Local<v8::String>, const v8::Prope
#if ENABLE(Condition11) || ENABLE(Condition12)
static void Node13AttributeSetter(v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)
{
+ ExceptionState exceptionState(ExceptionState::SetterContext, "Node13", "SupportTestInterface", info.Holder(), info.GetIsolate());
SupportTestInterface* imp = V8SupportTestInterface::toNative(info.Holder());
V8TRYCATCH_VOID(Node*, cppValue, V8Node::hasInstance(jsValue, info.GetIsolate(), worldType(info.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(jsValue)) : 0);
SupportTestPartialInterface::setNode13(imp, WTF::getPtr(cppValue));
@@ -287,6 +291,7 @@ static void Node14AttributeGetterCallback(v8::Local<v8::String>, const v8::Prope
#if ENABLE(Condition11) || ENABLE(Condition12)
static void Node14AttributeSetter(v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)
{
+ ExceptionState exceptionState(ExceptionState::SetterContext, "Node14", "SupportTestInterface", info.Holder(), info.GetIsolate());
SupportTestInterface* imp = V8SupportTestInterface::toNative(info.Holder());
V8TRYCATCH_VOID(Node*, cppValue, V8Node::hasInstance(jsValue, info.GetIsolate(), worldType(info.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(jsValue)) : 0);
SupportTestPartialInterface::setNode14(imp, WTF::getPtr(cppValue));
@@ -305,6 +310,7 @@ static void Node14AttributeSetterCallback(v8::Local<v8::String>, v8::Local<v8::V
#if ENABLE(Condition11) || ENABLE(Condition12)
static void supplementalMethod1Method(const v8::FunctionCallbackInfo<v8::Value>& info)
{
+ ExceptionState exceptionState(ExceptionState::ExecutionContext, "supplementalMethod1", "SupportTestInterface", info.Holder(), info.GetIsolate());
SupportTestInterface* imp = V8SupportTestInterface::toNative(info.Holder());
SupportTestPartialInterface::supplementalMethod1(imp);
}
@@ -322,12 +328,12 @@ static void supplementalMethod1MethodCallback(const v8::FunctionCallbackInfo<v8:
#if ENABLE(Condition11) || ENABLE(Condition12)
static void supplementalMethod2Method(const v8::FunctionCallbackInfo<v8::Value>& info)
{
+ ExceptionState exceptionState(ExceptionState::ExecutionContext, "supplementalMethod2", "SupportTestInterface", info.Holder(), info.GetIsolate());
if (UNLIKELY(info.Length() < 2)) {
throwTypeError(ExceptionMessages::failedToExecute("supplementalMethod2", "SupportTestInterface", ExceptionMessages::notEnoughArguments(2, info.Length())), info.GetIsolate());
return;
}
SupportTestInterface* imp = V8SupportTestInterface::toNative(info.Holder());
- ExceptionState exceptionState(info.Holder(), info.GetIsolate());
V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, strArg, info[0]);
V8TRYCATCH_VOID(TestObj*, objArg, V8TestObject::hasInstance(info[1], info.GetIsolate(), worldType(info.GetIsolate())) ? V8TestObject::toNative(v8::Handle<v8::Object>::Cast(info[1])) : 0);
ExecutionContext* scriptContext = getExecutionContext();
@@ -359,6 +365,7 @@ static void supplementalMethod3MethodCallback(const v8::FunctionCallbackInfo<v8:
#if ENABLE(Condition11) || ENABLE(Condition12)
static void supplementalMethod4Method(const v8::FunctionCallbackInfo<v8::Value>& info)
{
+ ExceptionState exceptionState(ExceptionState::ExecutionContext, "supplementalMethod4", "SupportTestInterface", info.Holder(), info.GetIsolate());
SupportTestPartialInterface::supplementalMethod4();
}
#endif // ENABLE(Condition11) || ENABLE(Condition12)

Powered by Google App Engine
This is Rietveld 408576698