Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 990723002: DM: display current memory usage (instead of peak) when available. (Closed)

Created:
5 years, 9 months ago by mtklein_C
Modified:
5 years, 9 months ago
Reviewers:
hal.canary, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

DM: display current memory usage (instead of peak) when available. Seems strictly more useful. This implements Mac and Windows, which seemed easy. Don't know how to do this on Linux yet. BUG=skia: CQ_EXTRA_TRYBOTS=client.skia:Test-Mac10.9-MacMini6.2-HD4000-x86_64-Debug-Trybot NOTREECHECKS=true TBR=halcanary@google.com Committed: https://skia.googlesource.com/skia/+/95553d917c73ef333ede967521560957a5b6a0ad

Patch Set 1 #

Patch Set 2 : windows too #

Patch Set 3 : curr #

Patch Set 4 : nanobench too #

Patch Set 5 : better best #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -16 lines) Patch
M bench/nanobench.cpp View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M dm/DM.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tools/ProcStats.h View 1 2 3 1 chunk +18 lines, -2 lines 0 comments Download
M tools/ProcStats.cpp View 1 2 3 chunks +22 lines, -9 lines 1 comment Download

Messages

Total messages: 26 (12 generated)
mtklein_C
5 years, 9 months ago (2015-03-08 16:10:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990723002/20001
5 years, 9 months ago (2015-03-08 16:11:05 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-08 16:11:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86_64-Debug-Trybot/builds/126)
5 years, 9 months ago (2015-03-08 16:14:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990723002/40001
5 years, 9 months ago (2015-03-08 16:17:35 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-08 16:17:36 UTC) #10
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 9 months ago (2015-03-08 22:17:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990723002/80001
5 years, 9 months ago (2015-03-10 19:20:54 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: Test-Win7-ShuttleA-HD2000-x86-Release-Trybot on client.skia (JOB_TIMED_OUT, no build URL) Timed out ...
5 years, 9 months ago (2015-03-10 21:21:14 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990723002/80001
5 years, 9 months ago (2015-03-10 21:54:52 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: Test-Win7-ShuttleA-HD2000-x86-Release-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Win7-ShuttleA-HD2000-x86-Release-Trybot/builds/40)
5 years, 9 months ago (2015-03-11 01:58:26 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990723002/80001
5 years, 9 months ago (2015-03-12 15:10:22 UTC) #23
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://skia.googlesource.com/skia/+/95553d917c73ef333ede967521560957a5b6a0ad
5 years, 9 months ago (2015-03-12 15:24:29 UTC) #24
hal.canary
5 years, 9 months ago (2015-03-16 17:22:34 UTC) #26
Message was sent while issue was closed.
https://codereview.chromium.org/990723002/diff/80001/tools/ProcStats.cpp
File tools/ProcStats.cpp (right):

https://codereview.chromium.org/990723002/diff/80001/tools/ProcStats.cpp#newc...
tools/ProcStats.cpp:50: #else
    #ifdef __linux
    #include <unistd.h>
    #include <stdio.h>
    int sk_tools::getCurrResidentSetSizeMB() {
        long pageSize = sysconf(_SC_PAGESIZE);
        FILE* statm = fopen("/proc/self/statm", "r");
        SkASSERT(statm != NULL);
        long rssPages;
        SkAssertResult(fscanf(statm, "%*d %ld", &rssPages) == 1);
        fclose(statm);
        return SkToInt(((int64_t)rssPages * pageSize) / (1024 * 1024));
    }
    #endif  // __linux

Powered by Google App Engine
This is Rietveld 408576698